Add VIR_MIGRATE_PARAM_TLS_DESTINATION constant

[libvirt] [perl][PATCH] Add VIR_MIGRATE_PARAM_TLS_DESTINATION constant

Posted by Michal Privoznik 4 years, 4 months ago

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 Changes                | 1 +
 lib/Sys/Virt.xs        | 1 +
 lib/Sys/Virt/Domain.pm | 9 +++++++++
 3 files changed, 11 insertions(+)

diff --git a/Changes b/Changes
index 37529ac..cf5d8cc 100644
--- a/Changes
+++ b/Changes
@@ -4,6 +4,7 @@ Revision history for perl module Sys::Virt
 
  - Add VIR_DOMAIN_JOB_SUCCESS and VIR_DOMAIN_JOB_STATS_KEEP_COMPLETED
    constants
+ - Add VIR_MIGRATE_PARAM_TLS_DESTINATION constant
 
 5.10.0 2019-12-03
 
diff --git a/lib/Sys/Virt.xs b/lib/Sys/Virt.xs
index 98a12d7..a729a52 100644
--- a/lib/Sys/Virt.xs
+++ b/lib/Sys/Virt.xs
@@ -9246,6 +9246,7 @@ BOOT:
       REGISTER_CONSTANT_STR(VIR_MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT, MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT);
       REGISTER_CONSTANT_STR(VIR_MIGRATE_PARAM_BANDWIDTH_POSTCOPY, MIGRATE_PARAM_BANDWIDTH_POSTCOPY);
       REGISTER_CONSTANT_STR(VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS, MIGRATE_PARAM_PARALLEL_CONNECTIONS);
+      REGISTER_CONSTANT_STR(VIR_MIGRATE_PARAM_TLS_DESTINATION, MIGRATE_PARAM_TLS_DESTINATION);
 
       REGISTER_CONSTANT(VIR_DOMAIN_MIGRATE_MAX_SPEED_POSTCOPY, MIGRATE_MAX_SPEED_POSTCOPY);
 
diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm
index 2caec51..ae909de 100644
--- a/lib/Sys/Virt/Domain.pm
+++ b/lib/Sys/Virt/Domain.pm
@@ -1141,6 +1141,15 @@ progress is not made
 
 The number of connections used during parallel migration.
 
+=item C<Sys::Virt::Domain::MIGRATE_PARAM_TLS_DESTINATION>
+
+Override the destination host name used for TLS verification.
+Normally the TLS certificate from the destination host must match
+the host's name for TLS verification to succeed. When the
+certificate does not match the destination hostname and the
+expected cetificate's hostname is known, this parameter can be
+used to pass this expected hostname when starting the migration.
+
 =back
 
 =item $ddom = $dom->migrate(destcon, flags=0, dname=undef, uri=undef, bandwidth=0)
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [perl][PATCH] Add VIR_MIGRATE_PARAM_TLS_DESTINATION constant

Posted by Daniel P. Berrangé 4 years, 4 months ago

On Tue, Dec 10, 2019 at 02:09:35PM +0100, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  Changes                | 1 +
>  lib/Sys/Virt.xs        | 1 +
>  lib/Sys/Virt/Domain.pm | 9 +++++++++
>  3 files changed, 11 insertions(+)
> 
> diff --git a/Changes b/Changes
> index 37529ac..cf5d8cc 100644
> --- a/Changes
> +++ b/Changes
> @@ -4,6 +4,7 @@ Revision history for perl module Sys::Virt
>  
>   - Add VIR_DOMAIN_JOB_SUCCESS and VIR_DOMAIN_JOB_STATS_KEEP_COMPLETED
>     constants
> + - Add VIR_MIGRATE_PARAM_TLS_DESTINATION constant
>  
>  5.10.0 2019-12-03
>  
> diff --git a/lib/Sys/Virt.xs b/lib/Sys/Virt.xs
> index 98a12d7..a729a52 100644
> --- a/lib/Sys/Virt.xs
> +++ b/lib/Sys/Virt.xs
> @@ -9246,6 +9246,7 @@ BOOT:
>        REGISTER_CONSTANT_STR(VIR_MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT, MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT);
>        REGISTER_CONSTANT_STR(VIR_MIGRATE_PARAM_BANDWIDTH_POSTCOPY, MIGRATE_PARAM_BANDWIDTH_POSTCOPY);
>        REGISTER_CONSTANT_STR(VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS, MIGRATE_PARAM_PARALLEL_CONNECTIONS);
> +      REGISTER_CONSTANT_STR(VIR_MIGRATE_PARAM_TLS_DESTINATION, MIGRATE_PARAM_TLS_DESTINATION);
>  
>        REGISTER_CONSTANT(VIR_DOMAIN_MIGRATE_MAX_SPEED_POSTCOPY, MIGRATE_MAX_SPEED_POSTCOPY);

This is incomplete, as the migrate methods need to be updated
to set the data type.

Don't bother about a v2 though as I'm co-incidentally fixing
this and many other perl bugs right now.

>  
> diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm
> index 2caec51..ae909de 100644
> --- a/lib/Sys/Virt/Domain.pm
> +++ b/lib/Sys/Virt/Domain.pm
> @@ -1141,6 +1141,15 @@ progress is not made
>  
>  The number of connections used during parallel migration.
>  
> +=item C<Sys::Virt::Domain::MIGRATE_PARAM_TLS_DESTINATION>
> +
> +Override the destination host name used for TLS verification.
> +Normally the TLS certificate from the destination host must match
> +the host's name for TLS verification to succeed. When the
> +certificate does not match the destination hostname and the
> +expected cetificate's hostname is known, this parameter can be
> +used to pass this expected hostname when starting the migration.

I'll borrow your description for my patch though

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list