virsh-snapshot: Don't leak @then in cmdSnapshotList()

[PATCH] virsh-snapshot: Don't leak @then in cmdSnapshotList()

Michal Privoznik posted 1 patch 2 years, 7 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/8f4bcefe4a5570547e5092e4c08cfc66dd8a5539.1629720608.git.mprivozn@redhat.com

tools/virsh-snapshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] virsh-snapshot: Don't leak @then in cmdSnapshotList()

Posted by Michal Privoznik 2 years, 7 months ago

The variable is used inside a loop in which it' allocated in each
iteration. Bring it inside the loop so that g_autoptr() kicks in
each iteration.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tools/virsh-snapshot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
index ee99d0e061..e08ecb6910 100644
--- a/tools/virsh-snapshot.c
+++ b/tools/virsh-snapshot.c
@@ -1439,7 +1439,6 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd)
     size_t i;
     virDomainSnapshotPtr snapshot = NULL;
     long long creation_longlong;
-    g_autoptr(GDateTime) then = NULL;
     bool tree = vshCommandOptBool(cmd, "tree");
     bool name = vshCommandOptBool(cmd, "name");
     bool from = vshCommandOptBool(cmd, "from");
@@ -1533,6 +1532,7 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd)
     }
 
     for (i = 0; i < snaplist->nsnaps; i++) {
+        g_autoptr(GDateTime) then = NULL;
         g_autofree gchar *thenstr = NULL;
         g_autoptr(xmlDoc) xml = NULL;
         g_autoptr(xmlXPathContext) ctxt = NULL;
-- 
2.31.1

Re: [PATCH] virsh-snapshot: Don't leak @then in cmdSnapshotList()

Posted by Ján Tomko 2 years, 7 months ago

On a Monday in 2021, Michal Privoznik wrote:
>The variable is used inside a loop in which it' allocated in each

it's

>iteration. Bring it inside the loop so that g_autoptr() kicks in
>each iteration.
>

Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2

>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> tools/virsh-snapshot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano