[PATCH] news: Update for upcoming release

Michal Privoznik posted 1 patch 1 week, 6 days ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/8ed1f5ab0af28ec04f70cf286d592bc6a8df1039.1617200426.git.mprivozn@redhat.com
NEWS.rst | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)

[PATCH] news: Update for upcoming release

Posted by Michal Privoznik 1 week, 6 days ago
Mention some of the stuff we dealt with in this release.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 NEWS.rst | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index 71f357e39f..f823fc8575 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -33,6 +33,11 @@ v7.2.0 (unreleased)
     backups (where only the difference since the last backup is copied) when
     qemu adds the required functionality.
 
+  * Add support for audio backend specific settings
+
+    With this release new ``<audio/>`` element is introduced that allows users
+    to configure audio output for their guests.
+
 * **Improvements**
 
   * qemu: Compatibility with QEMU 6.0 for certain hot-(un)-plug operations
@@ -41,8 +46,54 @@ v7.2.0 (unreleased)
     release for hotplug and hotunplug of certain devices and helpers, such as
     iothreads, chardevs, RNG devices, disks with secret, ...
 
+  * Various improvements for embed driver
+
+    The embed driver and ``virt-qemu-run`` tool saw improvements in handling of
+    domain life cycle, temporary directories creation (important when using
+    disk secrets) and other minor fixes.
+
+  * Documentation of split daemon related config files
+
+    Split daemons read configuration files upon their start. These were never
+    documented though.
+
 * **Bug fixes**
 
+  * Check host cpu for forbidden features
+
+    CPU feature policy did not work as expected with host-passthrough and
+    features supported by physical host. CPU features were not filtered out
+    when ``@check`` was set to ``full``.
+
+  * virNetworkUpdate() can not work with the split daemon
+
+    Due to a bug in our code, virNetworkUpdate() did not work with split daemon
+    unless management application connected to virtnetworkd directly.
+
+  * qemu: increase locked memory limit when a vDPA device is present
+
+    Just like VFIO devices, vDPA devices may need to have all guest memory
+    pages locked/pinned in order to operate properly. These devices are now
+    included when calculating the limit for memory lock.
+
+  * Don't log error if SRIOV PF has no associated netdev
+
+    Some SRIOV PFs don't have a netdev associated with them in which case
+    libvirtd reported an error and refused to start. This is now fixed.
+
+  * qemu: Only raise memlock limit if necessary
+
+    Attempting to set the memlock limit might fail if we're running
+    in a containerized environment where CAP_SYS_RESOURCE is not
+    available, and if the limit is already high enough there's no
+    point in trying to raise it anyway.
+
+  * Restore security context of swtpm.log
+
+    If a guest with emulated TPM was started and the daemon was restarted
+    afterwards, the security context of per domain swtmp.log file was not
+    restored on domain shutdown leaving it unable to be started again.
+
   * virtlogd|virtlockd: Fixed crash when upgrading the daemons in-place
 
     A bug preventing the in-place upgrade of ``virtlogd`` and ``virtlockd``
-- 
2.26.3

Re: [PATCH] news: Update for upcoming release

Posted by Andrea Bolognani 1 week, 6 days ago
On Wed, 2021-03-31 at 16:20 +0200, Michal Privoznik wrote:
> +  * Add support for audio backend specific settings
> +
> +    With this release new ``<audio/>`` element is introduced that allows users
> +    to configure audio output for their guests.

s/new/ a new/

> +  * Various improvements for embed driver
> +
> +    The embed driver and ``virt-qemu-run`` tool saw improvements in handling of
> +    domain life cycle, temporary directories creation (important when using
> +    disk secrets) and other minor fixes.

Perhaps a nit, but "embed driver" makes it sound like it's a separate
hypervisor driver, when in reality it's just the QEMU driver running
in embedded mode.

I suggest reworking this along the lines of

  qemu: Various improvements to embedded mode

  Embedded mode for the QEMU driver, as well as the
  ``virt-qemu-run`` tool, saw improvements [...]

> +  * Check host cpu for forbidden features

s/cpu/CPU/

> +    CPU feature policy did not work as expected with host-passthrough and

s/host-passthrough/``host-passthrough``/

> +  * virNetworkUpdate() can not work with the split daemon

This describes the original issue rather than the fix that was
applied to address it. Maybe use something like

  * Fix virNetworkUpdate() to work with split daemons

> +    Due to a bug in our code, virNetworkUpdate() did not work with split daemon
> +    unless management application connected to virtnetworkd directly.

s/virNetworkUpdate()/``virNetworkUpdate()``/

> +  * qemu: Only raise memlock limit if necessary
> +
> +    Attempting to set the memlock limit might fail if we're running
> +    in a containerized environment where CAP_SYS_RESOURCE is not
> +    available, and if the limit is already high enough there's no
> +    point in trying to raise it anyway.

s/CAP_SYS_RESOURCE/``CAP_SYS_RESOURCE``/

> +  * Restore security context of swtpm.log
> +
> +    If a guest with emulated TPM was started and the daemon was restarted
> +    afterwards, the security context of per domain swtmp.log file was not
> +    restored on domain shutdown leaving it unable to be started again.

s/per domain swtmp.log/the per-domain ``swtpm.log``/


Thanks a lot for taking care of this!

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH] news: Update for upcoming release

Posted by Ján Tomko 1 week, 6 days ago
On a Wednesday in 2021, Michal Privoznik wrote:
>Mention some of the stuff we dealt with in this release.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> NEWS.rst | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano