[libvirt PATCH] ci: Test with latest Avocado again

Erik Skultety posted 1 patch 1 year, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/81f47439fc4bc5f79d3b4ef525b1fd56bd405a82.1675867866.git.eskultet@redhat.com
ci/integration-template.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt PATCH] ci: Test with latest Avocado again
Posted by Erik Skultety 1 year, 2 months ago
Test with the following fix:
https://github.com/avocado-framework/avocado/pull/5567/commits

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---

The corresponding change in TCK needed for this was already merged:
https://gitlab.com/libvirt/libvirt-tck/-/merge_requests/37

Here's a relevant pipeline with the change applied:
https://gitlab.com/eskultety/libvirt/-/pipelines/770989394

Worth noting that because the change in TCK about Avocado wasn't backwards
compatible, we need to merge this one soon otherwise the next scheduled CI will
fail.

 ci/integration-template.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ci/integration-template.yml b/ci/integration-template.yml
index 9141d5cedf..efd04b76c1 100644
--- a/ci/integration-template.yml
+++ b/ci/integration-template.yml
@@ -28,7 +28,7 @@
   - sudo dnf install -y libvirt-rpms/* libvirt-perl-rpms/* libvirt-python-rpms/*
 
   # Avocado >98.0 fails with the nwfilter TCK tests, so stick with 98.0 for now
-  - sudo pip3 install --prefix=/usr avocado-framework==98.0
+  - sudo pip3 install --prefix=/usr avocado-framework
 
 
 .enable-core-dumps: &enable-core-dumps
-- 
2.39.1
Re: [libvirt PATCH] ci: Test with latest Avocado again
Posted by Daniel P. Berrangé 1 year, 2 months ago
On Wed, Feb 08, 2023 at 03:53:15PM +0100, Erik Skultety wrote:
> Test with the following fix:
> https://github.com/avocado-framework/avocado/pull/5567/commits
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
> 
> The corresponding change in TCK needed for this was already merged:
> https://gitlab.com/libvirt/libvirt-tck/-/merge_requests/37
> 
> Here's a relevant pipeline with the change applied:
> https://gitlab.com/eskultety/libvirt/-/pipelines/770989394
> 
> Worth noting that because the change in TCK about Avocado wasn't backwards
> compatible, we need to merge this one soon otherwise the next scheduled CI will
> fail.
> 
>  ci/integration-template.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ci/integration-template.yml b/ci/integration-template.yml
> index 9141d5cedf..efd04b76c1 100644
> --- a/ci/integration-template.yml
> +++ b/ci/integration-template.yml
> @@ -28,7 +28,7 @@
>    - sudo dnf install -y libvirt-rpms/* libvirt-perl-rpms/* libvirt-python-rpms/*
>  
>    # Avocado >98.0 fails with the nwfilter TCK tests, so stick with 98.0 for now
> -  - sudo pip3 install --prefix=/usr avocado-framework==98.0
> +  - sudo pip3 install --prefix=/usr avocado-framework
>  
>  
>  .enable-core-dumps: &enable-core-dumps


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|