manpage: virsh: Drop note that 'domrename' doesn't work with snapshots/checkpoints

[PATCH] manpage: virsh: Drop note that 'domrename' doesn't work with snapshots/checkpoints

Peter Krempa posted 1 patch 3 years, 3 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/79e318020768490c55c3f9995dfb01d7e13ba039.1609927142.git.pkrempa@redhat.com

docs/manpages/virsh.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] manpage: virsh: Drop note that 'domrename' doesn't work with snapshots/checkpoints

Posted by Peter Krempa 3 years, 3 months ago

As of commits 3b1244bffdb and 4770a96c662 renaming of the domain works
also with checkpoints and snapshots. Update the docs.

https://bugzilla.redhat.com/show_bug.cgi?id=1913138

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 docs/manpages/virsh.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 4a1500e686..e3afa48f7b 100644
--- a/docs/manpages/virsh.rst
+++ b/docs/manpages/virsh.rst
@@ -2177,7 +2177,7 @@ domrename
 Rename a domain. This command changes current domain name to the new name
 specified in the second argument.

-``Note``: Domain must be inactive and without snapshots or checkpoints.
+``Note``: Domain must be inactive.


 domstate
-- 
2.29.2

Re: [PATCH] manpage: virsh: Drop note that 'domrename' doesn't work with snapshots/checkpoints

Posted by Han Han 3 years, 3 months ago

On Wed, Jan 6, 2021 at 6:00 PM Peter Krempa <pkrempa@redhat.com> wrote:

> As of commits 3b1244bffdb and 4770a96c662 renaming of the domain works
> also with checkpoints and snapshots. Update the docs.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1913138
>
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  docs/manpages/virsh.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
> index 4a1500e686..e3afa48f7b 100644
> --- a/docs/manpages/virsh.rst
> +++ b/docs/manpages/virsh.rst
> @@ -2177,7 +2177,7 @@ domrename
>  Rename a domain. This command changes current domain name to the new name
>  specified in the second argument.
>
> -``Note``: Domain must be inactive and without snapshots or checkpoints.
> +``Note``: Domain must be inactive.
>
>
>  domstate
> --
> 2.29.2
>
>

-- 
Reviewed-by: Han Han <hhan@redhat.com>