Signed-off-by: Anya Harter <aharter@redhat.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index ca9e4e1..b2021d4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -44,3 +44,4 @@ vgcore.*
 /src/org.libvirt.service
 
 /tests/test_util
+**/.pytest_cache
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, 2018-07-10 at 10:00 -0400, Anya Harter wrote:
> gitignore: add tests/.pytest_cache
> 
> Signed-off-by: Anya Harter <aharter@redhat.com>

The commit message should have been adjusted - you're ignoring
all .pytest_cache/ directories now, not just the one in tests/ :)

[...]
> @@ -44,3 +44,4 @@ vgcore.*
>  /src/org.libvirt.service
>  
>  /tests/test_util
> +**/.pytest_cache

>From gitignore(5):

  A leading "**" followed by a slash means match in all
  directories. For example, "**/foo" matches file or directory
  "foo" anywhere, the same as pattern "foo".

So the first three characters are entirely unnecessary here: I've
dropped them, moved the pattern further up in the file (among all
other non-directory-specific patterns), fixed the commit message,
added my

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

and pushed the commit.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 07/10/2018 11:13 AM, Andrea Bolognani wrote:
> On Tue, 2018-07-10 at 10:00 -0400, Anya Harter wrote:
>> gitignore: add tests/.pytest_cache
>>
>> Signed-off-by: Anya Harter <aharter@redhat.com>
> 
> The commit message should have been adjusted - you're ignoring
> all .pytest_cache/ directories now, not just the one in tests/ :)
> 
> [...]
>> @@ -44,3 +44,4 @@ vgcore.*
>>  /src/org.libvirt.service
>>  
>>  /tests/test_util
>> +**/.pytest_cache
> 
> From gitignore(5):
> 
>   A leading "**" followed by a slash means match in all
>   directories. For example, "**/foo" matches file or directory
>   "foo" anywhere, the same as pattern "foo".
> 
> So the first three characters are entirely unnecessary here: I've
> dropped them, moved the pattern further up in the file (among all
> other non-directory-specific patterns), fixed the commit message,
> added my
> 
>   Reviewed-by: Andrea Bolognani <abologna@redhat.com>
> 
> and pushed the commit.
Sorry, I'm still pretty new to .gitignore files. :)

Thanks!

Anya

> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, 2018-07-10 at 11:18 -0400, Anya Harter wrote:
> Sorry, I'm still pretty new to .gitignore files. :)

No worries, that's exactly what reviews are for :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list