remoteDispatchConnectOpen: Fix check for 'BHYVE' connection type

[PATCH] remoteDispatchConnectOpen: Fix check for 'BHYVE' connection type

Posted by Peter Krempa 3 months ago

From: aokblast <aokblast@FreeBSD.org>

'bhyveConnectGetType' (which is called from 'virConnectGetType') returns
'BHYVE' as the type, but the code in 'remoteDispatchConnectOpen'
responsible for selecting the sub-driver URIs in modular deployment
checks for 'bhyve' and thus would not properly fill the URIs to the
sub-daemons.

Signed-off-by: aokblast <aokblast@FreeBSD.org>
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/remote/remote_daemon_dispatch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
index cfffb40095..e812f5c3e9 100644
--- a/src/remote/remote_daemon_dispatch.c
+++ b/src/remote/remote_daemon_dispatch.c
@@ -2108,7 +2108,7 @@ remoteDispatchConnectOpen(virNetServer *server G_GNUC_UNUSED,
         STREQ(type, "Xen") ||
         STREQ(type, "LXC") ||
         STREQ(type, "VBOX") ||
-        STREQ(type, "bhyve") ||
+        STREQ(type, "BHYVE") ||
         STREQ(type, "vz") ||
         STREQ(type, "Parallels") ||
         STREQ(type, "CH")) {
-- 
2.46.0

Re: [PATCH] remoteDispatchConnectOpen: Fix check for 'BHYVE' connection type

Posted by Pavel Hrdina 3 months ago

On Mon, Aug 26, 2024 at 02:31:33PM +0200, Peter Krempa wrote:
> From: aokblast <aokblast@FreeBSD.org>
> 
> 'bhyveConnectGetType' (which is called from 'virConnectGetType') returns
> 'BHYVE' as the type, but the code in 'remoteDispatchConnectOpen'
> responsible for selecting the sub-driver URIs in modular deployment
> checks for 'bhyve' and thus would not properly fill the URIs to the
> sub-daemons.
> 
> Signed-off-by: aokblast <aokblast@FreeBSD.org>
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/remote/remote_daemon_dispatch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>