[libvirt PATCH] meson: error out when ch driver is requested but unsupported

Ján Tomko posted 1 patch 16 hours ago
There is a newer version of this series
meson.build | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
[libvirt PATCH] meson: error out when ch driver is requested but unsupported
Posted by Ján Tomko 16 hours ago
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 meson.build | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/meson.build b/meson.build
index 16ec3ba7e2..326d9dd0f9 100644
--- a/meson.build
+++ b/meson.build
@@ -1582,8 +1582,12 @@ elif get_option('driver_lxc').enabled()
   error('linux and remote_driver are required for LXC')
 endif
 
-if not get_option('driver_ch').disabled() and host_machine.system() == 'linux' and (host_machine.cpu_family() == 'x86_64' or host_machine.cpu_family() == 'aarch64')
-  use_ch = true
+if not get_option('driver_ch').disabled()
+  if host_machine.system() == 'linux' and (host_machine.cpu_family() == 'x86_64' or host_machine.cpu_family() == 'aarch64')
+    use_ch = true
+  elif get_option('driver_ch').enabled()
+    error('linux on x86_64 or aarch64 is required to build Cloud-Hypervisor driver')
+  endif
 
   if not conf.has('WITH_LIBVIRTD')
     use_ch = false
-- 
2.47.0
Re: [libvirt PATCH] meson: error out when ch driver is requested but unsupported
Posted by Daniel P. Berrangé 16 hours ago
On Mon, Jan 20, 2025 at 10:16:25AM +0100, Ján Tomko wrote:
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  meson.build | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|