[libvirt] [PATCH] spec: fix indentation

Ján Tomko posted 1 patch 4 years, 11 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/6b8ab20f9b9b1a9383bd2cb9a075f57beb196c1c.1576069895.git.jtomko@redhat.com
libvirt.spec.in | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
[libvirt] [PATCH] spec: fix indentation
Posted by Ján Tomko 4 years, 11 months ago
The recent specfile addition broke syntax-check:
cppi: ../libvirt.spec.in: line 338: not properly indented
cppi: ../libvirt.spec.in: line 341: not properly indented
cppi: ../libvirt.spec.in: line 344: not properly indented

Fixes: ac063cb2e76d64a907f96bf0b6a29da4eb484ebc
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
Push under the 'are we still doing syntax-check?' rule

 libvirt.spec.in | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 01f28e62d6..4d75fbecaf 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -335,13 +335,13 @@ BuildRequires: device-mapper-devel
 # For XFS reflink clone support
 BuildRequires: xfsprogs-devel
 %if %{with_storage_rbd}
-%if 0%{?fedora} || 0%{?rhel} > 7
-BuildRequires: librados-devel
-BuildRequires: librbd-devel
-%else
-BuildRequires: librados2-devel
-BuildRequires: librbd1-devel
-%endif
+    %if 0%{?fedora} || 0%{?rhel} > 7
+        BuildRequires: librados-devel
+        BuildRequires: librbd-devel
+    %else
+        BuildRequires: librados2-devel
+        BuildRequires: librbd1-devel
+    %endif
 %endif
 %if %{with_storage_gluster}
 BuildRequires: glusterfs-api-devel >= 3.4.1
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] spec: fix indentation
Posted by Peter Krempa 4 years, 11 months ago
On Wed, Dec 11, 2019 at 14:12:34 +0100, Ján Tomko wrote:
> The recent specfile addition broke syntax-check:
> cppi: ../libvirt.spec.in: line 338: not properly indented
> cppi: ../libvirt.spec.in: line 341: not properly indented
> cppi: ../libvirt.spec.in: line 344: not properly indented
> 
> Fixes: ac063cb2e76d64a907f96bf0b6a29da4eb484ebc
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
> Push under the 'are we still doing syntax-check?' rule
> 
>  libvirt.spec.in | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 01f28e62d6..4d75fbecaf 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -335,13 +335,13 @@ BuildRequires: device-mapper-devel
>  # For XFS reflink clone support
>  BuildRequires: xfsprogs-devel
>  %if %{with_storage_rbd}
> -%if 0%{?fedora} || 0%{?rhel} > 7
> -BuildRequires: librados-devel
> -BuildRequires: librbd-devel
> -%else
> -BuildRequires: librados2-devel
> -BuildRequires: librbd1-devel
> -%endif
> +    %if 0%{?fedora} || 0%{?rhel} > 7
> +        BuildRequires: librados-devel
> +        BuildRequires: librbd-devel

I don't think you are supposed to indent these. In fact none other are
indented at all.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list