[PATCH] spec: Drop numad usage on fedora 39+

Cole Robinson posted 1 patch 5 days, 1 hour ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/650fa274da0d20e5cbfb4607bdd71284017c4770.1684862939.git.crobinso@redhat.com
libvirt.spec.in | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] spec: Drop numad usage on fedora 39+
Posted by Cole Robinson 5 days, 1 hour ago
numad is removed from Fedora 39. Upstream is dead

https://src.fedoraproject.org/rpms/numad/c/a6bb891e8447e3b2a4c63774da94ad0d9b4ee50a?branch=rawhide
https://pagure.io/releng/failed-composes/issue/4990#comment-857670

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---

This powers vcpu and numatune placement='auto'. Anyone know if that's
being actively used in kubevirt, openstack, etc?

 libvirt.spec.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 1f77cd90b7..5f267a086b 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -173,6 +173,10 @@
         %define with_numad    0%{!?_without_numad:1}
     %endif
 %endif
+%if 0%{?fedora} >= 39
+    # numad is retired in fedora 39+, upstream is dead
+    %define with_numad        0
+%endif
 
 %ifarch %{arches_dmidecode}
     %define with_dmidecode 0%{!?_without_dmidecode:1}
-- 
2.40.1
Re: [PATCH] spec: Drop numad usage on fedora 39+
Posted by Martin Kletzander 4 days, 8 hours ago
On Tue, May 23, 2023 at 01:31:01PM -0400, Cole Robinson wrote:
>numad is removed from Fedora 39. Upstream is dead
>
>https://src.fedoraproject.org/rpms/numad/c/a6bb891e8447e3b2a4c63774da94ad0d9b4ee50a?branch=rawhide
>https://pagure.io/releng/failed-composes/issue/4990#comment-857670
>
>Signed-off-by: Cole Robinson <crobinso@redhat.com>
>---
>
>This powers vcpu and numatune placement='auto'. Anyone know if that's
>being actively used in kubevirt, openstack, etc?
>

I hope not.

> libvirt.spec.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/libvirt.spec.in b/libvirt.spec.in
>index 1f77cd90b7..5f267a086b 100644
>--- a/libvirt.spec.in
>+++ b/libvirt.spec.in
>@@ -173,6 +173,10 @@
>         %define with_numad    0%{!?_without_numad:1}
>     %endif
> %endif
>+%if 0%{?fedora} >= 39
>+    # numad is retired in fedora 39+, upstream is dead
>+    %define with_numad        0
>+%endif
>

And I'm fine with this.

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

> %ifarch %{arches_dmidecode}
>     %define with_dmidecode 0%{!?_without_dmidecode:1}
>-- 
>2.40.1
>