numad is removed from Fedora 39. Upstream is dead
https://src.fedoraproject.org/rpms/numad/c/a6bb891e8447e3b2a4c63774da94ad0d9b4ee50a?branch=rawhide
https://pagure.io/releng/failed-composes/issue/4990#comment-857670
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
This powers vcpu and numatune placement='auto'. Anyone know if that's
being actively used in kubevirt, openstack, etc?
libvirt.spec.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 1f77cd90b7..5f267a086b 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -173,6 +173,10 @@
%define with_numad 0%{!?_without_numad:1}
%endif
%endif
+%if 0%{?fedora} >= 39
+ # numad is retired in fedora 39+, upstream is dead
+ %define with_numad 0
+%endif
%ifarch %{arches_dmidecode}
%define with_dmidecode 0%{!?_without_dmidecode:1}
--
2.40.1
On 5/23/23 19:31, Cole Robinson wrote: > numad is removed from Fedora 39. Upstream is dead > > https://src.fedoraproject.org/rpms/numad/c/a6bb891e8447e3b2a4c63774da94ad0d9b4ee50a?branch=rawhide > https://pagure.io/releng/failed-composes/issue/4990#comment-857670 > > Signed-off-by: Cole Robinson <crobinso@redhat.com> > --- > > This powers vcpu and numatune placement='auto'. Anyone know if that's > being actively used in kubevirt, openstack, etc? > > libvirt.spec.in | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 1f77cd90b7..5f267a086b 100644 > --- a/libvirt.spec.in > +++ b/libvirt.spec.in > @@ -173,6 +173,10 @@ > %define with_numad 0%{!?_without_numad:1} > %endif > %endif > +%if 0%{?fedora} >= 39 > + # numad is retired in fedora 39+, upstream is dead > + %define with_numad 0 > +%endif Actually, it was just added back: https://pagure.io/releng/issue/11445 https://src.fedoraproject.org/rpms/numad/c/e0d0e47bbdabc8d915a61796e2e027d89d454c6e?branch=rawhide So maybe we will need to revert this? Or we may pretend that we never saw that and just carry on. I doubt numad had any users (I mean, from libvirt users group). Michal
On Mon, Jun 05, 2023 at 12:10:03PM +0200, Michal Prívozník wrote: >On 5/23/23 19:31, Cole Robinson wrote: >> numad is removed from Fedora 39. Upstream is dead >> >> https://src.fedoraproject.org/rpms/numad/c/a6bb891e8447e3b2a4c63774da94ad0d9b4ee50a?branch=rawhide >> https://pagure.io/releng/failed-composes/issue/4990#comment-857670 >> >> Signed-off-by: Cole Robinson <crobinso@redhat.com> >> --- >> >> This powers vcpu and numatune placement='auto'. Anyone know if that's >> being actively used in kubevirt, openstack, etc? >> >> libvirt.spec.in | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/libvirt.spec.in b/libvirt.spec.in >> index 1f77cd90b7..5f267a086b 100644 >> --- a/libvirt.spec.in >> +++ b/libvirt.spec.in >> @@ -173,6 +173,10 @@ >> %define with_numad 0%{!?_without_numad:1} >> %endif >> %endif >> +%if 0%{?fedora} >= 39 >> + # numad is retired in fedora 39+, upstream is dead >> + %define with_numad 0 >> +%endif > >Actually, it was just added back: > >https://pagure.io/releng/issue/11445 > >https://src.fedoraproject.org/rpms/numad/c/e0d0e47bbdabc8d915a61796e2e027d89d454c6e?branch=rawhide > >So maybe we will need to revert this? Or we may pretend that we never >saw that and just carry on. I doubt numad had any users (I mean, from >libvirt users group). > I have never seen your e-mail that mentions this. Yes, I'm talking about the one I am replying to right here. That e-mail never existed. >Michal >
On Thu, Jun 08, 2023 at 08:53:17AM +0200, Martin Kletzander wrote: > On Mon, Jun 05, 2023 at 12:10:03PM +0200, Michal Prívozník wrote: > > On 5/23/23 19:31, Cole Robinson wrote: > > > +%if 0%{?fedora} >= 39 > > > + # numad is retired in fedora 39+, upstream is dead > > > + %define with_numad 0 > > > +%endif > > > > Actually, it was just added back: > > > > https://pagure.io/releng/issue/11445 > > > > https://src.fedoraproject.org/rpms/numad/c/e0d0e47bbdabc8d915a61796e2e027d89d454c6e?branch=rawhide > > > > So maybe we will need to revert this? Or we may pretend that we never > > saw that and just carry on. I doubt numad had any users (I mean, from > > libvirt users group). Luckily this was never pushed so we don't need to take any action, but just in case I'll leave an explicit NACK here. -- Andrea Bolognani / Red Hat / Virtualization
On Tue, May 23, 2023 at 01:31:01PM -0400, Cole Robinson wrote: >numad is removed from Fedora 39. Upstream is dead > >https://src.fedoraproject.org/rpms/numad/c/a6bb891e8447e3b2a4c63774da94ad0d9b4ee50a?branch=rawhide >https://pagure.io/releng/failed-composes/issue/4990#comment-857670 > >Signed-off-by: Cole Robinson <crobinso@redhat.com> >--- > >This powers vcpu and numatune placement='auto'. Anyone know if that's >being actively used in kubevirt, openstack, etc? > I hope not. > libvirt.spec.in | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/libvirt.spec.in b/libvirt.spec.in >index 1f77cd90b7..5f267a086b 100644 >--- a/libvirt.spec.in >+++ b/libvirt.spec.in >@@ -173,6 +173,10 @@ > %define with_numad 0%{!?_without_numad:1} > %endif > %endif >+%if 0%{?fedora} >= 39 >+ # numad is retired in fedora 39+, upstream is dead >+ %define with_numad 0 >+%endif > And I'm fine with this. Reviewed-by: Martin Kletzander <mkletzan@redhat.com> > %ifarch %{arches_dmidecode} > %define with_dmidecode 0%{!?_without_dmidecode:1} >-- >2.40.1 >
© 2016 - 2024 Red Hat, Inc.