Fixes breakage of 'sc_linguas_sorting'.

Fixes: c886a40cfcbceb2efa57930b64f758d3e263d759
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
Pushed as a build fix. Whether that syntax check is a sensible use of
CPU cycles is for another discussion.

 po/LINGUAS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/po/LINGUAS b/po/LINGUAS
index 33418f7705..490a76b5d4 100644
--- a/po/LINGUAS
+++ b/po/LINGUAS
@@ -17,6 +17,7 @@ hu
 id
 it
 ja
+ka
 kn
 ko
 mk
@@ -42,4 +43,3 @@ uk
 vi
 zh_CN
 zh_TW
-ka
-- 
2.36.1

On Tue, Jun 14, 2022 at 02:39:46PM +0200, Peter Krempa wrote:
> Fixes breakage of 'sc_linguas_sorting'.
> 
> Fixes: c886a40cfcbceb2efa57930b64f758d3e263d759
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
> Pushed as a build fix. Whether that syntax check is a sensible use of
> CPU cycles is for another discussion.


po/LINGUAS is created by weblate automatically with no human
interaction, so if we don't accept whatever weblate gives
us we won't be able to merge changes from weblate....

...except that due to an accident with our CI we've not
blocked on that.

Our CI is accidentally triggering on both branch pushes
and merge requests, and the merge request trigger doesnt
run the syntax-check job.

We need to drop that syntax-check rule, and also fix our
CI.

> 
>  po/LINGUAS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/po/LINGUAS b/po/LINGUAS
> index 33418f7705..490a76b5d4 100644
> --- a/po/LINGUAS
> +++ b/po/LINGUAS
> @@ -17,6 +17,7 @@ hu
>  id
>  it
>  ja
> +ka
>  kn
>  ko
>  mk
> @@ -42,4 +43,3 @@ uk
>  vi
>  zh_CN
>  zh_TW
> -ka
> -- 
> 2.36.1
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

On Tue, Jun 14, 2022 at 01:52:28PM +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 14, 2022 at 02:39:46PM +0200, Peter Krempa wrote:
> > Pushed as a build fix. Whether that syntax check is a sensible use of
> > CPU cycles is for another discussion.
>
> po/LINGUAS is created by weblate automatically with no human
> interaction, so if we don't accept whatever weblate gives
> us we won't be able to merge changes from weblate....
>
> ...except that due to an accident with our CI we've not
> blocked on that.
>
> Our CI is accidentally triggering on both branch pushes
> and merge requests, and the merge request trigger doesnt
> run the syntax-check job.
>
> We need to drop that syntax-check rule, and also fix our
> CI.

I added the syntax-check rule without realizing that the file was
automatically generated. I agree that we should drop it. But at least
it made us spot an issue in our CI, so it wasn't all for nothing :)

-- 
Andrea Bolognani / Red Hat / Virtualization

On Fri, Jun 17, 2022 at 05:09:38AM -0700, Andrea Bolognani wrote:
> On Tue, Jun 14, 2022 at 01:52:28PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Jun 14, 2022 at 02:39:46PM +0200, Peter Krempa wrote:
> > > Pushed as a build fix. Whether that syntax check is a sensible use of
> > > CPU cycles is for another discussion.
> >
> > po/LINGUAS is created by weblate automatically with no human
> > interaction, so if we don't accept whatever weblate gives
> > us we won't be able to merge changes from weblate....
> >
> > ...except that due to an accident with our CI we've not
> > blocked on that.
> >
> > Our CI is accidentally triggering on both branch pushes
> > and merge requests, and the merge request trigger doesnt
> > run the syntax-check job.
> >
> > We need to drop that syntax-check rule, and also fix our
> > CI.
> 
> I added the syntax-check rule without realizing that the file was
> automatically generated. I agree that we should drop it. But at least
> it made us spot an issue in our CI, so it wasn't all for nothing :)

Perhaps file a bug against weblate asking them to change their
code to keep the file sorted.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|