docs: kbase: Tune how CPU support for SEV should be queried

[libvirt PATCH] docs: kbase: Tune how CPU support for SEV should be queried

Erik Skultety posted 1 patch 3 years, 7 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/5ddb16d9866fd99c40c150addd06ffb245fc8665.1599744047.git.eskultet@redhat.com

docs/kbase/launch_security_sev.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH] docs: kbase: Tune how CPU support for SEV should be queried

Posted by Erik Skultety 3 years, 7 months ago

 #useless_use_of_cat

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---

Dedicated to everyone who felt deeply offended by the useless use of cat :).

 docs/kbase/launch_security_sev.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/kbase/launch_security_sev.rst b/docs/kbase/launch_security_sev.rst
index 4a37c0c379..8f58413261 100644
--- a/docs/kbase/launch_security_sev.rst
+++ b/docs/kbase/launch_security_sev.rst
@@ -38,7 +38,7 @@ You can manually check whether SEV is among the CPU flags with:

 ::

-   $ cat /proc/cpuinfo | grep sev
+   $ grep -w sev /proc/cpuinfo
    ...
    sme ssbd sev ibpb

--
2.26.2

Re: [libvirt PATCH] docs: kbase: Tune how CPU support for SEV should be queried

Posted by Daniel P. Berrangé 3 years, 7 months ago

On Thu, Sep 10, 2020 at 03:22:51PM +0200, Erik Skultety wrote:
>  #useless_use_of_cat
>

You also changed semantics to avoid accidental sub-string matches....

> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
> 
> Dedicated to everyone who felt deeply offended by the useless use of cat :).
> 
>  docs/kbase/launch_security_sev.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/kbase/launch_security_sev.rst b/docs/kbase/launch_security_sev.rst
> index 4a37c0c379..8f58413261 100644
> --- a/docs/kbase/launch_security_sev.rst
> +++ b/docs/kbase/launch_security_sev.rst
> @@ -38,7 +38,7 @@ You can manually check whether SEV is among the CPU flags with:
> 
>  ::
> 
> -   $ cat /proc/cpuinfo | grep sev
> +   $ grep -w sev /proc/cpuinfo
>     ...
>     sme ssbd sev ibpb

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|