qemuHotplugDiskSourceDataFree: also free backends

[libvirt] [PATCH] qemuHotplugDiskSourceDataFree: also free backends

Ján Tomko posted 1 patch 5 years ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/5a2fec380f37eed1854fd4346e5a8a95b73f2dae.1554906252.git.jtomko@redhat.com

src/qemu/qemu_hotplug.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[libvirt] [PATCH] qemuHotplugDiskSourceDataFree: also free backends

Posted by Ján Tomko 5 years ago

Also free the backends array, not just its members.

Fixes: d3f9dda2c9fd9fa7d2f7f1f1dd70ed7d83938101

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_hotplug.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 34249bd030..540befba68 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -512,6 +512,7 @@ qemuHotplugDiskSourceDataFree(qemuHotplugDiskSourceDataPtr data)
     for (i = 0; i < data->nbackends; i++)
         qemuBlockStorageSourceAttachDataFree(data->backends[i]);
 
+    VIR_FREE(data->backends);
     VIR_FREE(data);
 }
 
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemuHotplugDiskSourceDataFree: also free backends

Posted by Peter Krempa 5 years ago

On Wed, Apr 10, 2019 at 16:24:14 +0200, Ján Tomko wrote:
> Also free the backends array, not just its members.
> 
> Fixes: d3f9dda2c9fd9fa7d2f7f1f1dd70ed7d83938101
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_hotplug.c | 1 +
>  1 file changed, 1 insertion(+)

Oops, ACK.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list