tools: spell out the type instead of using typeof

[libvirt PATCH] tools: spell out the type instead of using typeof

Posted by Ján Tomko 3 years, 6 months ago

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 tools/virsh-completer-domain.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c
index 50a8a31fcd..c657627ac1 100644
--- a/tools/virsh-completer-domain.c
+++ b/tools/virsh-completer-domain.c
@@ -357,7 +357,7 @@ virshDomainInterfaceAddrSourceCompleter(vshControl *ctl G_GNUC_UNUSED,
 
     virCheckFlags(0, NULL);
 
-    ret = g_new0(typeof(*ret), VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LAST + 1);
+    ret = g_new0(char *, VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LAST + 1);
 
     for (i = 0; i < VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LAST; i++)
         ret[i] = g_strdup(virshDomainInterfaceAddressesSourceTypeToString(i));
@@ -376,7 +376,7 @@ virshDomainHostnameSourceCompleter(vshControl *ctl G_GNUC_UNUSED,
 
     virCheckFlags(0, NULL);
 
-    ret = g_new0(typeof(*ret), VIRSH_DOMAIN_HOSTNAME_SOURCE_LAST + 1);
+    ret = g_new0(char *, VIRSH_DOMAIN_HOSTNAME_SOURCE_LAST + 1);
 
     for (i = 0; i < VIRSH_DOMAIN_HOSTNAME_SOURCE_LAST; i++)
         ret[i] = g_strdup(virshDomainHostnameSourceTypeToString(i));
-- 
2.26.2

Re: [libvirt PATCH] tools: spell out the type instead of using typeof

Posted by Daniel Henrique Barboza 3 years, 6 months ago


On 10/7/20 4:10 PM, Ján Tomko wrote:
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   tools/virsh-completer-domain.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c
> index 50a8a31fcd..c657627ac1 100644
> --- a/tools/virsh-completer-domain.c
> +++ b/tools/virsh-completer-domain.c
> @@ -357,7 +357,7 @@ virshDomainInterfaceAddrSourceCompleter(vshControl *ctl G_GNUC_UNUSED,
>   
>       virCheckFlags(0, NULL);
>   
> -    ret = g_new0(typeof(*ret), VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LAST + 1);
> +    ret = g_new0(char *, VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LAST + 1);
>   
>       for (i = 0; i < VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LAST; i++)
>           ret[i] = g_strdup(virshDomainInterfaceAddressesSourceTypeToString(i));
> @@ -376,7 +376,7 @@ virshDomainHostnameSourceCompleter(vshControl *ctl G_GNUC_UNUSED,
>   
>       virCheckFlags(0, NULL);
>   
> -    ret = g_new0(typeof(*ret), VIRSH_DOMAIN_HOSTNAME_SOURCE_LAST + 1);
> +    ret = g_new0(char *, VIRSH_DOMAIN_HOSTNAME_SOURCE_LAST + 1);
>   
>       for (i = 0; i < VIRSH_DOMAIN_HOSTNAME_SOURCE_LAST; i++)
>           ret[i] = g_strdup(virshDomainHostnameSourceTypeToString(i));
>