[libvirt PATCH] src/storage/meson: fix vir_storage_file_gluster module dependencies

Pavel Hrdina posted 1 patch 2 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/57b532a4d79db0391c4232382e841cd9614b70be.1599572911.git.phrdina@redhat.com
src/storage/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt PATCH] src/storage/meson: fix vir_storage_file_gluster module dependencies

Posted by Pavel Hrdina 2 weeks ago
The correct key for dependencies for virt_modules hash is `deps`.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 src/storage/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/storage/meson.build b/src/storage/meson.build
index 18ea0f3fb5..b4cefe9a89 100644
--- a/src/storage/meson.build
+++ b/src/storage/meson.build
@@ -187,7 +187,7 @@ if conf.has('WITH_STORAGE_GLUSTER')
     'sources': [
       files(storage_file_gluster_sources),
     ],
-    'dependenciec': [
+    'deps': [
       glusterfs_dep,
     ],
     'install_dir': storage_file_install_dir,
-- 
2.26.2

Re: [libvirt PATCH] src/storage/meson: fix vir_storage_file_gluster module dependencies

Posted by Ján Tomko 2 weeks ago
On a Tuesday in 2020, Pavel Hrdina wrote:
>The correct key for dependencies for virt_modules hash is `deps`.
>

s/dependencies/dependenciec/

>Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>---
> src/storage/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

Re: [libvirt PATCH] src/storage/meson: fix vir_storage_file_gluster module dependencies

Posted by Pavel Hrdina 2 weeks ago
On Tue, Sep 08, 2020 at 04:41:03PM +0200, Ján Tomko wrote:
> On a Tuesday in 2020, Pavel Hrdina wrote:
> > The correct key for dependencies for virt_modules hash is `deps`.
> > 
> 
> s/dependencies/dependenciec/

No :) it's not used here as the incorrect key but as regular word with
its meaning.

Re: [libvirt PATCH] src/storage/meson: fix vir_storage_file_gluster module dependencies

Posted by Andrea Bolognani 2 weeks ago
On Tue, 2020-09-08 at 15:48 +0200, Pavel Hrdina wrote:
> The correct key for dependencies for virt_modules hash is `deps`.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  src/storage/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH] src/storage/meson: fix vir_storage_file_gluster module dependencies

Posted by Peter Krempa 2 weeks ago
On Tue, Sep 08, 2020 at 15:48:46 +0200, Pavel Hrdina wrote:
> The correct key for dependencies for virt_modules hash is `deps`.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  src/storage/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>