[libvirt] [PATCH] Add some news items for the 3.4.0 release

Martin Kletzander posted 1 patch 6 years, 10 months ago
Failed in applying to current master (apply log)
docs/news.xml | 166 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 165 insertions(+), 1 deletion(-)
[libvirt] [PATCH] Add some news items for the 3.4.0 release
Posted by Martin Kletzander 6 years, 10 months ago
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
I could not be bothered to split the patches.  Also, please review
whatever you know about as this is just a compilation of stuff from
the git log.

 docs/news.xml | 166 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 165 insertions(+), 1 deletion(-)

diff --git a/docs/news.xml b/docs/news.xml
index 649350a904d3..d34e8beae4c0 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -45,6 +45,38 @@
           sparseness.
         </description>
       </change>
+      <change>
+        <summary>
+          I/O APIC type can be specified for QEMU/KVM domains
+        </summary>
+        <description>
+          The <code>ioapic</code> tag was added to domain
+          <code>features</code>, so the type of the I/O APIC can now
+          be specified (e.g. putting it in userspace for KVM domains).
+        </description>
+      </change>
+      <change>
+        <summary>
+          Repository now has new README.md file
+        </summary>
+        <description>
+          The new file uses markdown syntax, so it looks better on
+          github and possibly other web pages, but it has also more
+          useful information.  The old README is now symlink to the
+          new file.
+        </description>
+      </change>
+      <change>
+        <summary>
+          The reason for VM shutdown is reported, if known
+        </summary>
+        <description>
+          QEMU 2.10 will be able to report the reason for shutting
+          down (whether that was caused by the guest or not), and
+          libvirt is prepared for that and reports that information in
+          its shutdown event as well, if it is known.
+        </description>
+      </change>
     </section>
     <section title="Improvements">
       <change>
@@ -67,10 +99,142 @@
           is for CCW devices, most common on the S390 architecture. The second
           is for fibre channel-backed SCSI devices and exposes the
           fc_remote_port sub-capability to SCSI target devices.
-       </description>
+        </description>
+      </change>
+      <change>
+        <summary>
+          Node devices now report Mediated device capabilities
+        </summary>
+        <description>
+          Endpoint devices support new <code>mdev</code> capability
+          and their parents now report the supported types in new
+          <code>mdev_types</mdev> capability.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Capabilities now report information about host caches
+        </summary>
+        <description>
+          If supported in the kernel, host capabilities will now list
+          L3 caches.  The code for other levels was added as well, but
+          only L3 caches are reported currently.
+        </description>
+      </change>
+      <change>
+        <summary>
+          POWER9 CPU model was added
+        </summary>
+        <description>
+          It is now properly reported in host capabilities.
+        </description>
+      </change>
+      <change>
+        <summary>
+          libxl: NUMA sibling distances are now reported in host capabilities
+        </summary>
+      </change>
+      <change>
+        <summary>
+          Support for VMDK files with version 3
+        </summary>
+        <description>
+          VMDK version 3 files are now properly detected.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Interrupt remapping and Extended interrupt mode for IOMMU devices
+        </summary>
+        <description>
+          These two new features can now be controlled with new
+          <code>&lt;driver intremap='on/off' eim='on/off'/&gt;</code>
+          tag for <code>iommu</code> devices.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Graphics in libxl domains now have default addresses
+        </summary>
+        <description>
+          Even though there were default addresses before this change,
+          they were not saved in the XML.  It is now possible to see
+          and control the listen addresses properly.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Default USB controllers are now added for devices in libxl domains
+        </summary>
+        <description>
+          Even though they were added automatically when USB device
+          was attached, they could've been missing in some other
+          cases.  The logic is now fixed so there are always USB
+          controllers, even if there was none of them in the specified
+          XML.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Limits for RPC messages were increased
+        </summary>
+        <description>
+          Hitting the RPC limits we have is easier every day, so they
+          were increased once again and some guessing logic was
+          improved as well.  It is now possible to get more stats than
+          ever using the <code>virConnectGetAllDomainStats()</code>
+          call and push through even bigger requests and replies for
+          all APIs.
+        </description>
       </change>
     </section>
     <section title="Bug fixes">
+      <change>
+        <summary>
+          PCIe 4.0 cards now report proper link speeds
+        </summary>
+        <description>
+          It could happen that the link speed for PCIe devices was not
+          properly reported or the nodedev-dumpxml just failed.  That
+          was due to mistake in the field width, but should now work
+          properly.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Do not report errors on shutdown
+        </summary>
+        <description>
+          For some users, in some rare cases, it could happen that
+          there was an error message "internal error: End of file from
+          qemu monitor" in the logs even though no problem happened.
+          The detection of these false positives was improved and such
+          errors should not show any more.
+        </description>
+      </change>
+      <change>
+        <summary>
+          User-specified UNIX socket paths for virtio channels should not be reset
+        </summary>
+        <description>
+          It could happen, in some cases, that libvirt would mistake a
+          user-specified path for its own generated one and thus
+          remove it from the XML.  The detection of such addresses was
+          improved now.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Fix address reservation during RNG hot-plug
+        </summary>
+        <description>
+          When error occurred in a specific point in time during the
+          hot-plug of an RNG device, it could happen that an address
+          was released even though another device was already using
+          it, making it possible to hot-plug another device with that
+          address, effectively having duplicated addresses in the XML.
+        </description>
+      </change>
     </section>
   </release>
   <release version="v3.3.0" date="2017-05-05">
--
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
Posted by Peter Krempa 6 years, 10 months ago
On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
> I could not be bothered to split the patches.  Also, please review
> whatever you know about as this is just a compilation of stuff from
> the git log.
> 
>  docs/news.xml | 166 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 165 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 649350a904d3..d34e8beae4c0 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -45,6 +45,38 @@

[...]

> +      <change>
> +        <summary>
> +          Repository now has new README.md file
> +        </summary>
> +        <description>
> +          The new file uses markdown syntax, so it looks better on
> +          github and possibly other web pages, but it has also more
> +          useful information.  The old README is now symlink to the
> +          new file.
> +        </description>
> +      </change>

This does not seem to be a feature to me in any possible way.

> @@ -67,10 +99,142 @@

[...]

> +      <change>
> +        <summary>
> +          libxl: NUMA sibling distances are now reported in host capabilities
> +        </summary>
> +      </change>
> +      <change>
> +        <summary>
> +          Support for VMDK files with version 3
> +        </summary>
> +        <description>
> +          VMDK version 3 files are now properly detected.

Was this description suggested by the department of redundancy
department?

> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          Interrupt remapping and Extended interrupt mode for IOMMU devices
> +        </summary>
> +        <description>
> +          These two new features can now be controlled with new
> +          <code>&lt;driver intremap='on/off' eim='on/off'/&gt;</code>
> +          tag for <code>iommu</code> devices.
> +        </description>
> +      </change>

Why was the other iommu change considered a feature and this is an
improvement?


ACK to everything excepthe readme.md section.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
Posted by Martin Kletzander 6 years, 10 months ago
On Wed, May 31, 2017 at 04:22:07PM +0200, Peter Krempa wrote:
>On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote:
>> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>> ---
>> I could not be bothered to split the patches.  Also, please review
>> whatever you know about as this is just a compilation of stuff from
>> the git log.
>>
>>  docs/news.xml | 166 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 165 insertions(+), 1 deletion(-)
>>
>> diff --git a/docs/news.xml b/docs/news.xml
>> index 649350a904d3..d34e8beae4c0 100644
>> --- a/docs/news.xml
>> +++ b/docs/news.xml
>> @@ -45,6 +45,38 @@
>
>[...]
>
>> +      <change>
>> +        <summary>
>> +          Repository now has new README.md file
>> +        </summary>
>> +        <description>
>> +          The new file uses markdown syntax, so it looks better on
>> +          github and possibly other web pages, but it has also more
>> +          useful information.  The old README is now symlink to the
>> +          new file.
>> +        </description>
>> +      </change>
>
>This does not seem to be a feature to me in any possible way.
>

I probably wanted to put it in Improvements, can that be?

>> @@ -67,10 +99,142 @@
>
>[...]
>
>> +      <change>
>> +        <summary>
>> +          libxl: NUMA sibling distances are now reported in host capabilities
>> +        </summary>
>> +      </change>
>> +      <change>
>> +        <summary>
>> +          Support for VMDK files with version 3
>> +        </summary>
>> +        <description>
>> +          VMDK version 3 files are now properly detected.
>
>Was this description suggested by the department of redundancy
>department?
>

I'll go with just "VMDK version 3 files are now properly detected" as a summary.


>> +        </description>
>> +      </change>
>> +      <change>
>> +        <summary>
>> +          Interrupt remapping and Extended interrupt mode for IOMMU devices
>> +        </summary>
>> +        <description>
>> +          These two new features can now be controlled with new
>> +          <code>&lt;driver intremap='on/off' eim='on/off'/&gt;</code>
>> +          tag for <code>iommu</code> devices.
>> +        </description>
>> +      </change>
>
>Why was the other iommu change considered a feature and this is an
>improvement?
>

What other iommu change?  I can't find any in this file.

>
>ACK to everything excepthe readme.md section.

Please, reconsider with this squashed in, since there was off-list reply
with double spaces as well:

diff --git i/docs/news.xml w/docs/news.xml
index d34e8beae4c0..b351f22990a1 100644
--- i/docs/news.xml
+++ w/docs/news.xml
@@ -57,17 +57,6 @@
       </change>
       <change>
         <summary>
-          Repository now has new README.md file
-        </summary>
-        <description>
-          The new file uses markdown syntax, so it looks better on
-          github and possibly other web pages, but it has also more
-          useful information.  The old README is now symlink to the
-          new file.
-        </description>
-      </change>
-      <change>
-        <summary>
           The reason for VM shutdown is reported, if known
         </summary>
         <description>
@@ -81,6 +70,17 @@
     <section title="Improvements">
       <change>
         <summary>
+          Repository now has new README.md file
+        </summary>
+        <description>
+          The new file uses markdown syntax, so it looks better on
+          github and possibly other web pages, but it has also more
+          useful information. The old README is now symlink to the
+          new file.
+        </description>
+      </change>
+      <change>
+        <summary>
           qemu: Use GICv2 by default for aarch64/virt TCG guests
         </summary>
         <description>
@@ -117,7 +117,7 @@
         </summary>
         <description>
           If supported in the kernel, host capabilities will now list
-          L3 caches.  The code for other levels was added as well, but
+          L3 caches. The code for other levels was added as well, but
           only L3 caches are reported currently.
         </description>
       </change>
@@ -136,11 +136,8 @@
       </change>
       <change>
         <summary>
-          Support for VMDK files with version 3
+          VMDK version 3 files are now properly detected
         </summary>
-        <description>
-          VMDK version 3 files are now properly detected.
-        </description>
       </change>
       <change>
         <summary>
@@ -158,7 +155,7 @@
         </summary>
         <description>
           Even though there were default addresses before this change,
-          they were not saved in the XML.  It is now possible to see
+          they were not saved in the XML. It is now possible to see
           and control the listen addresses properly.
         </description>
       </change>
@@ -169,7 +166,7 @@
         <description>
           Even though they were added automatically when USB device
           was attached, they could've been missing in some other
-          cases.  The logic is now fixed so there are always USB
+          cases. The logic is now fixed so there are always USB
           controllers, even if there was none of them in the specified
           XML.
         </description>
@@ -181,7 +178,7 @@
         <description>
           Hitting the RPC limits we have is easier every day, so they
           were increased once again and some guessing logic was
-          improved as well.  It is now possible to get more stats than
+          improved as well. It is now possible to get more stats than
           ever using the <code>virConnectGetAllDomainStats()</code>
           call and push through even bigger requests and replies for
           all APIs.
@@ -195,7 +192,7 @@
         </summary>
         <description>
           It could happen that the link speed for PCIe devices was not
-          properly reported or the nodedev-dumpxml just failed.  That
+          properly reported or the nodedev-dumpxml just failed. That
           was due to mistake in the field width, but should now work
           properly.
         </description>
@@ -219,7 +216,7 @@
         <description>
           It could happen, in some cases, that libvirt would mistake a
           user-specified path for its own generated one and thus
-          remove it from the XML.  The detection of such addresses was
+          remove it from the XML. The detection of such addresses was
           improved now.
         </description>
       </change>
@@ -407,7 +404,7 @@
           NVDIMM is new type of memory introduced into QEMU 2.6. The idea is
           that we have a non-volatile memory module that keeps the data
           persistent across domain reboots and offers much faster data
-          accesses.  However, due to a bug in QEMU, this feature is not enabled
+          accesses. However, due to a bug in QEMU, this feature is not enabled
           for QEMUs older than 2.9.0.
         </description>
       </change>
--

Martin
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
Posted by Martin Kletzander 6 years, 10 months ago
On Wed, May 31, 2017 at 05:35:52PM +0200, Martin Kletzander wrote:
>On Wed, May 31, 2017 at 04:22:07PM +0200, Peter Krempa wrote:
>>On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote:
>>> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>>> ---
>>> I could not be bothered to split the patches.  Also, please review
>>> whatever you know about as this is just a compilation of stuff from
>>> the git log.
>>>
>>>  docs/news.xml | 166 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>>  1 file changed, 165 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/docs/news.xml b/docs/news.xml
>>> index 649350a904d3..d34e8beae4c0 100644
>>> --- a/docs/news.xml
>>> +++ b/docs/news.xml
>>> @@ -45,6 +45,38 @@
>>
>>[...]
>>
>>> +      <change>
>>> +        <summary>
>>> +          Repository now has new README.md file
>>> +        </summary>
>>> +        <description>
>>> +          The new file uses markdown syntax, so it looks better on
>>> +          github and possibly other web pages, but it has also more
>>> +          useful information.  The old README is now symlink to the
>>> +          new file.
>>> +        </description>
>>> +      </change>
>>
>>This does not seem to be a feature to me in any possible way.
>>
>
>I probably wanted to put it in Improvements, can that be?
>
>>> @@ -67,10 +99,142 @@
>>
>>[...]
>>
>>> +      <change>
>>> +        <summary>
>>> +          libxl: NUMA sibling distances are now reported in host capabilities
>>> +        </summary>
>>> +      </change>
>>> +      <change>
>>> +        <summary>
>>> +          Support for VMDK files with version 3
>>> +        </summary>
>>> +        <description>
>>> +          VMDK version 3 files are now properly detected.
>>
>>Was this description suggested by the department of redundancy
>>department?
>>
>
>I'll go with just "VMDK version 3 files are now properly detected" as a summary.
>
>
>>> +        </description>
>>> +      </change>
>>> +      <change>
>>> +        <summary>
>>> +          Interrupt remapping and Extended interrupt mode for IOMMU devices
>>> +        </summary>
>>> +        <description>
>>> +          These two new features can now be controlled with new
>>> +          <code>&lt;driver intremap='on/off' eim='on/off'/&gt;</code>
>>> +          tag for <code>iommu</code> devices.
>>> +        </description>
>>> +      </change>
>>
>>Why was the other iommu change considered a feature and this is an
>>improvement?
>>
>
>What other iommu change?  I can't find any in this file.
>
>>
>>ACK to everything excepthe readme.md section.
>
>Please, reconsider with this squashed in, since there was off-list reply
>with double spaces as well:
>
>diff --git i/docs/news.xml w/docs/news.xml
>index d34e8beae4c0..b351f22990a1 100644
>--- i/docs/news.xml
>+++ w/docs/news.xml
>@@ -57,17 +57,6 @@
>       </change>
>       <change>
>         <summary>
>-          Repository now has new README.md file
>-        </summary>
>-        <description>
>-          The new file uses markdown syntax, so it looks better on
>-          github and possibly other web pages, but it has also more
>-          useful information.  The old README is now symlink to the
>-          new file.
>-        </description>
>-      </change>
>-      <change>
>-        <summary>
>           The reason for VM shutdown is reported, if known
>         </summary>
>         <description>
>@@ -81,6 +70,17 @@
>     <section title="Improvements">
>       <change>
>         <summary>
>+          Repository now has new README.md file
>+        </summary>
>+        <description>
>+          The new file uses markdown syntax, so it looks better on
>+          github and possibly other web pages, but it has also more
>+          useful information. The old README is now symlink to the
>+          new file.
>+        </description>
>+      </change>
>+      <change>
>+        <summary>
>           qemu: Use GICv2 by default for aarch64/virt TCG guests
>         </summary>
>         <description>
>@@ -117,7 +117,7 @@
>         </summary>
>         <description>
>           If supported in the kernel, host capabilities will now list
>-          L3 caches.  The code for other levels was added as well, but
>+          L3 caches. The code for other levels was added as well, but
>           only L3 caches are reported currently.
>         </description>
>       </change>
>@@ -136,11 +136,8 @@
>       </change>
>       <change>
>         <summary>
>-          Support for VMDK files with version 3
>+          VMDK version 3 files are now properly detected
>         </summary>
>-        <description>
>-          VMDK version 3 files are now properly detected.
>-        </description>
>       </change>
>       <change>
>         <summary>
>@@ -158,7 +155,7 @@
>         </summary>
>         <description>
>           Even though there were default addresses before this change,
>-          they were not saved in the XML.  It is now possible to see
>+          they were not saved in the XML. It is now possible to see
>           and control the listen addresses properly.
>         </description>
>       </change>
>@@ -169,7 +166,7 @@
>         <description>
>           Even though they were added automatically when USB device
>           was attached, they could've been missing in some other
>-          cases.  The logic is now fixed so there are always USB
>+          cases. The logic is now fixed so there are always USB
>           controllers, even if there was none of them in the specified
>           XML.
>         </description>
>@@ -181,7 +178,7 @@
>         <description>
>           Hitting the RPC limits we have is easier every day, so they
>           were increased once again and some guessing logic was
>-          improved as well.  It is now possible to get more stats than
>+          improved as well. It is now possible to get more stats than
>           ever using the <code>virConnectGetAllDomainStats()</code>
>           call and push through even bigger requests and replies for
>           all APIs.
>@@ -195,7 +192,7 @@
>         </summary>
>         <description>
>           It could happen that the link speed for PCIe devices was not
>-          properly reported or the nodedev-dumpxml just failed.  That
>+          properly reported or the nodedev-dumpxml just failed. That
>           was due to mistake in the field width, but should now work
>           properly.
>         </description>
>@@ -219,7 +216,7 @@
>         <description>
>           It could happen, in some cases, that libvirt would mistake a
>           user-specified path for its own generated one and thus
>-          remove it from the XML.  The detection of such addresses was
>+          remove it from the XML. The detection of such addresses was
>           improved now.
>         </description>
>       </change>
>@@ -407,7 +404,7 @@
>           NVDIMM is new type of memory introduced into QEMU 2.6. The idea is
>           that we have a non-volatile memory module that keeps the data
>           persistent across domain reboots and offers much faster data
>-          accesses.  However, due to a bug in QEMU, this feature is not enabled
>+          accesses. However, due to a bug in QEMU, this feature is not enabled
>           for QEMUs older than 2.9.0.

Of course except this last hunk as that is for an older version, I'm
rushing too much, I'll rather send a v2 tomorrow then regret the bunny
ears yet again.

>         </description>
>       </change>
>--
>
>Martin



>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
Posted by Andrea Bolognani 6 years, 10 months ago
On Wed, 2017-05-31 at 17:44 +0200, Martin Kletzander wrote:
> > @@ -407,7 +404,7 @@
> >           NVDIMM is new type of memory introduced into QEMU 2.6. The idea is
> >           that we have a non-volatile memory module that keeps the data
> >           persistent across domain reboots and offers much faster data
> > -          accesses.  However, due to a bug in QEMU, this feature is not enabled
> > +          accesses. However, due to a bug in QEMU, this feature is not enabled
> >           for QEMUs older than 2.9.0.
> 
> Of course except this last hunk as that is for an older version, I'm
> rushing too much, I'll rather send a v2 tomorrow then regret the bunny
> ears yet again.

I don't feel like news entries become entirely immutable
after the release is out; in particular, performing minor
style tweaks like this one or fixing typos is perfectly
acceptable IMHO, as it improves the overall document without
changing its meaning or attempting to rewrite history.

And I'm pretty sure removing an extra space from this file
will not cause the build to fail, so no risk of bunny ears ;)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
Posted by Martin Kletzander 6 years, 10 months ago
On Thu, Jun 01, 2017 at 09:48:45AM +0200, Andrea Bolognani wrote:
>On Wed, 2017-05-31 at 17:44 +0200, Martin Kletzander wrote:
>> > @@ -407,7 +404,7 @@
>> >           NVDIMM is new type of memory introduced into QEMU 2.6. The idea is
>> >           that we have a non-volatile memory module that keeps the data
>> >           persistent across domain reboots and offers much faster data
>> > -          accesses.  However, due to a bug in QEMU, this feature is not enabled
>> > +          accesses. However, due to a bug in QEMU, this feature is not enabled
>> >           for QEMUs older than 2.9.0.
>> 
>> Of course except this last hunk as that is for an older version, I'm
>> rushing too much, I'll rather send a v2 tomorrow then regret the bunny
>> ears yet again.
>
>I don't feel like news entries become entirely immutable
>after the release is out; in particular, performing minor
>style tweaks like this one or fixing typos is perfectly
>acceptable IMHO, as it improves the overall document without
>changing its meaning or attempting to rewrite history.
>

Sure, I just meant it's not part of this patch.  I pushed both of them
now, hopefully it looks like it should, feel free to check it out ;)

>And I'm pretty sure removing an extra space from this file
>will not cause the build to fail, so no risk of bunny ears ;)
>
>-- 
>Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Add some news items for the 3.4.0 release
Posted by Peter Krempa 6 years, 10 months ago
On Wed, May 31, 2017 at 17:35:52 +0200, Martin Kletzander wrote:
> On Wed, May 31, 2017 at 04:22:07PM +0200, Peter Krempa wrote:
> > On Wed, May 31, 2017 at 16:06:48 +0200, Martin Kletzander wrote:
> > > Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> > > ---
> > > I could not be bothered to split the patches.  Also, please review
> > > whatever you know about as this is just a compilation of stuff from
> > > the git log.
> > > 
> > >  docs/news.xml | 166 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > >  1 file changed, 165 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/docs/news.xml b/docs/news.xml
> > > index 649350a904d3..d34e8beae4c0 100644
> > > --- a/docs/news.xml
> > > +++ b/docs/news.xml
> > > @@ -45,6 +45,38 @@
> > 
> > [...]
> > 
> > > +      <change>
> > > +        <summary>
> > > +          Repository now has new README.md file
> > > +        </summary>
> > > +        <description>
> > > +          The new file uses markdown syntax, so it looks better on
> > > +          github and possibly other web pages, but it has also more
> > > +          useful information.  The old README is now symlink to the
> > > +          new file.
> > > +        </description>
> > > +      </change>
> > 
> > This does not seem to be a feature to me in any possible way.
> > 
> 
> I probably wanted to put it in Improvements, can that be?

I don't feel that adding that file improved anything, but yes, that is
the more appropriate place.

> 
> > > @@ -67,10 +99,142 @@
> > 
> > [...]
> > 
> > > +      <change>
> > > +        <summary>
> > > +          libxl: NUMA sibling distances are now reported in host capabilities
> > > +        </summary>
> > > +      </change>
> > > +      <change>
> > > +        <summary>
> > > +          Support for VMDK files with version 3
> > > +        </summary>
> > > +        <description>
> > > +          VMDK version 3 files are now properly detected.
> > 
> > Was this description suggested by the department of redundancy
> > department?
> > 
> 
> I'll go with just "VMDK version 3 files are now properly detected" as a summary.

That's exactly what I've meant :)

> 
> 
> > > +        </description>
> > > +      </change>
> > > +      <change>
> > > +        <summary>
> > > +          Interrupt remapping and Extended interrupt mode for IOMMU devices
> > > +        </summary>
> > > +        <description>
> > > +          These two new features can now be controlled with new
> > > +          <code>&lt;driver intremap='on/off' eim='on/off'/&gt;</code>
> > > +          tag for <code>iommu</code> devices.
> > > +        </description>
> > > +      </change>
> > 
> > Why was the other iommu change considered a feature and this is an
> > improvement?
> > 
> 
> What other iommu change?  I can't find any in this file.


> 
> > 
> > ACK to everything excepthe readme.md section.

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list