build: Fix the go build caused by a missing commentary end sequence

[libvirt] [libvirt-go PATCH] build: Fix the go build caused by a missing commentary end sequence

Posted by Erik Skultety 5 years, 5 months ago

Commit 20ab0c4d added a new constant to reflect recent libvirt upstream
changes. However, it also introduced a tiny typo which caused the build
to fail.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
Pushed both under trivial and build-breaker rules.

 domain_compat.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/domain_compat.h b/domain_compat.h
index 5069ea2..371bcc4 100644
--- a/domain_compat.h
+++ b/domain_compat.h
@@ -911,7 +911,7 @@ struct _virDomainInterface {
 #define VIR_DOMAIN_MEMORY_STAT_DISK_CACHES 10
 #endif

-/* 4.10.0
+/* 4.10.0 */

 #ifndef VIR_DOMAIN_SHUTOFF_DAEMON
 #define VIR_DOMAIN_SHUTOFF_DAEMON 8
--
2.19.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-go PATCH] build: Fix the go build caused by a missing commentary end sequence

Posted by Daniel P. Berrangé 5 years, 5 months ago

On Thu, Nov 15, 2018 at 08:28:57AM +0100, Erik Skultety wrote:
> Commit 20ab0c4d added a new constant to reflect recent libvirt upstream
> changes. However, it also introduced a tiny typo which caused the build
> to fail.

Urgh thanks, I had it locally but forgot to commit the typo fix
before pushing.

> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
> Pushed both under trivial and build-breaker rules.
> 
>  domain_compat.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/domain_compat.h b/domain_compat.h
> index 5069ea2..371bcc4 100644
> --- a/domain_compat.h
> +++ b/domain_compat.h
> @@ -911,7 +911,7 @@ struct _virDomainInterface {
>  #define VIR_DOMAIN_MEMORY_STAT_DISK_CACHES 10
>  #endif
> 
> -/* 4.10.0
> +/* 4.10.0 */
> 
>  #ifndef VIR_DOMAIN_SHUTOFF_DAEMON
>  #define VIR_DOMAIN_SHUTOFF_DAEMON 8
> --
> 2.19.1
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list