[PATCH] spec: Only build ch driver on x86_64 and aarch64

Cole Robinson posted 1 patch 3 days, 8 hours ago
libvirt.spec.in | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] spec: Only build ch driver on x86_64 and aarch64
Posted by Cole Robinson 3 days, 8 hours ago
This matches the cpu_family() check in `meson.build`

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---

note: something probably needs to be fixed on meson.build side too,
since an explicit `driver_ch=enabled` doesn't generate a build
error.

 libvirt.spec.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 2bc8dfd323..5a1755d74f 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -29,6 +29,7 @@
 %define arches_zfs              %{arches_x86} %{power64} %{arm}
 %define arches_numactl          %{arches_x86} %{power64} aarch64 s390x
 %define arches_numad            %{arches_x86} %{power64} aarch64
+%define arches_ch               x86_64 aarch64
 
 # The hypervisor drivers that run in libvirtd
 %define with_qemu          0%{!?_without_qemu:1}
@@ -124,6 +125,9 @@
 %ifnarch %{arches_ceph}
     %define with_storage_rbd 0
 %endif
+%ifnarch %{arches_ch}
+    %define with_ch 0
+%endif
 
 # RHEL doesn't ship many hypervisor drivers
 %if 0%{?rhel}
-- 
2.48.1
Re: [PATCH] spec: Only build ch driver on x86_64 and aarch64
Posted by Daniel P. Berrangé 16 hours ago
On Fri, Jan 17, 2025 at 12:05:07PM -0500, Cole Robinson wrote:
> This matches the cpu_family() check in `meson.build`
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> 
> note: something probably needs to be fixed on meson.build side too,
> since an explicit `driver_ch=enabled` doesn't generate a build
> error.
> 
>  libvirt.spec.in | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|