spec: Delay supported_platform check

[libvirt] [PATCH] spec: Delay supported_platform check

Posted by Jiri Denemark 6 years, 6 months ago

Building RPM should only be allowed on a supported platform, but
unpacking the source and applying all patches can be done anywhere.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 libvirt.spec.in | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index a3bd77f8a4..48f193f0c4 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1091,10 +1091,6 @@ Libvirt plugin for NSS for translating domain names into IP addresses.
 
 
 %prep
-%if ! %{supported_platform}
-echo "This RPM requires either Fedora >= 20 or RHEL >= 6"
-exit 1
-%endif
 
 %setup -q
 
@@ -1135,6 +1131,11 @@ rm -f $PATCHLIST
 rm -rf .git
 
 %build
+%if ! %{supported_platform}
+echo "This RPM requires either Fedora >= 20 or RHEL >= 6"
+exit 1
+%endif
+
 %if %{with_xen}
     %define arg_xen --with-xen
 %else
-- 
2.14.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Delay supported_platform check

Posted by Martin Kletzander 6 years, 6 months ago

On Tue, Oct 03, 2017 at 01:48:04PM +0200, Jiri Denemark wrote:
>Building RPM should only be allowed on a supported platform, but
>unpacking the source and applying all patches can be done anywhere.
>
>Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
>---
> libvirt.spec.in | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>

ACK, trivial

>diff --git a/libvirt.spec.in b/libvirt.spec.in
>index a3bd77f8a4..48f193f0c4 100644
>--- a/libvirt.spec.in
>+++ b/libvirt.spec.in
>@@ -1091,10 +1091,6 @@ Libvirt plugin for NSS for translating domain names into IP addresses.
>
>
> %prep
>-%if ! %{supported_platform}
>-echo "This RPM requires either Fedora >= 20 or RHEL >= 6"
>-exit 1
>-%endif
>
> %setup -q
>
>@@ -1135,6 +1131,11 @@ rm -f $PATCHLIST
> rm -rf .git
>
> %build
>+%if ! %{supported_platform}
>+echo "This RPM requires either Fedora >= 20 or RHEL >= 6"
>+exit 1
>+%endif
>+
> %if %{with_xen}
>     %define arg_xen --with-xen
> %else
>-- 
>2.14.2
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Delay supported_platform check

Posted by Daniel P. Berrange 6 years, 6 months ago

On Tue, Oct 03, 2017 at 01:48:04PM +0200, Jiri Denemark wrote:
> Building RPM should only be allowed on a supported platform, but
> unpacking the source and applying all patches can be done anywhere.
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  libvirt.spec.in | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

ACK


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list