check the return value of qemuBuildVirtioOptionsStr

[libvirt] [PATCH] check the return value of qemuBuildVirtioOptionsStr

Posted by Ján Tomko 6 years, 10 months ago

Only qemuBuildFSDevStr missed the return check.
---
 src/qemu/qemu_command.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 900239f05..57893cfda 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -2527,7 +2527,8 @@ qemuBuildFSDevStr(const virDomainDef *def,
                       QEMU_FSDEV_HOST_PREFIX, fs->info.alias);
     virBufferAsprintf(&opt, ",mount_tag=%s", fs->dst);
 
-    qemuBuildVirtioOptionsStr(&opt, fs->virtio, qemuCaps);
+    if (qemuBuildVirtioOptionsStr(&opt, fs->virtio, qemuCaps) < 0)
+        goto error;
 
     if (qemuBuildDeviceAddressStr(&opt, def, &fs->info, qemuCaps) < 0)
         goto error;
-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] check the return value of qemuBuildVirtioOptionsStr

Posted by Jiri Denemark 6 years, 10 months ago

On Tue, Jun 20, 2017 at 12:25:10 +0200, Ján Tomko wrote:
> Only qemuBuildFSDevStr missed the return check.
> ---
>  src/qemu/qemu_command.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 900239f05..57893cfda 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -2527,7 +2527,8 @@ qemuBuildFSDevStr(const virDomainDef *def,
>                        QEMU_FSDEV_HOST_PREFIX, fs->info.alias);
>      virBufferAsprintf(&opt, ",mount_tag=%s", fs->dst);
>  
> -    qemuBuildVirtioOptionsStr(&opt, fs->virtio, qemuCaps);
> +    if (qemuBuildVirtioOptionsStr(&opt, fs->virtio, qemuCaps) < 0)
> +        goto error;
>  
>      if (qemuBuildDeviceAddressStr(&opt, def, &fs->info, qemuCaps) < 0)
>          goto error;

ACK

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] check the return value of qemuBuildVirtioOptionsStr

Posted by Pavel Hrdina 6 years, 10 months ago

On Tue, Jun 20, 2017 at 12:25:10PM +0200, Ján Tomko wrote:
> Only qemuBuildFSDevStr missed the return check.
> ---
>  src/qemu/qemu_command.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list