[libvirt] [PATCH] bootstrap.conf: drop c-strcasestr gnulib module

Pavel Hrdina posted 1 patch 4 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/47f183071086ebd477b27cdc102d7330115f9383.1574173370.git.phrdina@redhat.com
bootstrap.conf               | 1 -
src/qemu/qemu_monitor_json.c | 1 -
2 files changed, 2 deletions(-)
[libvirt] [PATCH] bootstrap.conf: drop c-strcasestr gnulib module
Posted by Pavel Hrdina 4 years, 5 months ago
Last usage was removed by commit
<41f88886198e231285cc813f8c0687c8ec5c9488> and commit
<0f4d31720430b4e3735064cc0d8f88a1a438e154> forgot to drop include.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 bootstrap.conf               | 1 -
 src/qemu/qemu_monitor_json.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 4c784487e2..3eab6e1f3c 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -24,7 +24,6 @@ bind
 byteswap
 c-ctype
 c-strcase
-c-strcasestr
 canonicalize-lgpl
 chown
 clock-time
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 10f6a4cadc..fb662cb18b 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -40,7 +40,6 @@
 #include "virprobe.h"
 #include "virstring.h"
 #include "cpu/cpu_x86.h"
-#include "c-strcasestr.h"
 #include "virenum.h"
 
 #ifdef WITH_DTRACE_PROBES
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] bootstrap.conf: drop c-strcasestr gnulib module
Posted by Fabiano Fidêncio 4 years, 5 months ago
On Tue, Nov 19, 2019 at 3:25 PM Pavel Hrdina <phrdina@redhat.com> wrote:
>
> Last usage was removed by commit
> <41f88886198e231285cc813f8c0687c8ec5c9488> and commit
> <0f4d31720430b4e3735064cc0d8f88a1a438e154> forgot to drop include.
>
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  bootstrap.conf               | 1 -
>  src/qemu/qemu_monitor_json.c | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/bootstrap.conf b/bootstrap.conf
> index 4c784487e2..3eab6e1f3c 100644
> --- a/bootstrap.conf
> +++ b/bootstrap.conf
> @@ -24,7 +24,6 @@ bind
>  byteswap
>  c-ctype
>  c-strcase
> -c-strcasestr
>  canonicalize-lgpl
>  chown
>  clock-time
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index 10f6a4cadc..fb662cb18b 100644
> --- a/src/qemu/qemu_monitor_json.c
> +++ b/src/qemu/qemu_monitor_json.c
> @@ -40,7 +40,6 @@
>  #include "virprobe.h"
>  #include "virstring.h"
>  #include "cpu/cpu_x86.h"
> -#include "c-strcasestr.h"
>  #include "virenum.h"
>
>  #ifdef WITH_DTRACE_PROBES
> --
> 2.23.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] bootstrap.conf: drop c-strcasestr gnulib module
Posted by Peter Krempa 4 years, 5 months ago
On Tue, Nov 19, 2019 at 15:22:58 +0100, Pavel Hrdina wrote:
> Last usage was removed by commit
> <41f88886198e231285cc813f8c0687c8ec5c9488> and commit
> <0f4d31720430b4e3735064cc0d8f88a1a438e154> forgot to drop include.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  bootstrap.conf               | 1 -
>  src/qemu/qemu_monitor_json.c | 1 -
>  2 files changed, 2 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

I'll add it to my gnulib module cleansing series which I'll post in a
while.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list