NEWS: Mention snapshot quiesce rollback bugfix

[PATCH] NEWS: Mention snapshot quiesce rollback bugfix

Posted by Peter Krempa 3 years, 2 months ago

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 NEWS.rst | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index 440dbf2601..8d639253ff 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -51,6 +51,20 @@ v7.1.0 (unreleased)

 * **Bug fixes**

+  * qemu: Fix disk quiescing rollback when creating external snapshots
+
+   If the qemu guest agent call to freeze filesystems failed when creating
+   an external snapshot with ``VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE`` flag the
+   filesystems would be unconditionally thawed. This could cause problems when
+   the filesystems were frozen by an explicit call to ``virDomainFSFreeze``
+   since the guest agent then rejects any further freeze attempts once are
+   filesystems frozen, an explicit freeze followed by a quiesced snapshot
+   would fail and thaw filesystems.
+
+   Users are also encouraged to use ``virDomainFSFreeze/Thaw`` manually instead
+   of relying on ``VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE`` if they need finer
+   grained control.
+

 v7.0.0 (2021-01-15)
 ===================
-- 
2.29.2

Re: [PATCH] NEWS: Mention snapshot quiesce rollback bugfix

Posted by Ján Tomko 3 years, 2 months ago

On a Monday in 2021, Peter Krempa wrote:
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> NEWS.rst | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>diff --git a/NEWS.rst b/NEWS.rst
>index 440dbf2601..8d639253ff 100644
>--- a/NEWS.rst
>+++ b/NEWS.rst
>@@ -51,6 +51,20 @@ v7.1.0 (unreleased)
>
> * **Bug fixes**
>
>+  * qemu: Fix disk quiescing rollback when creating external snapshots
>+
>+   If the qemu guest agent call to freeze filesystems failed when creating
>+   an external snapshot with ``VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE`` flag the
>+   filesystems would be unconditionally thawed. This could cause problems when
>+   the filesystems were frozen by an explicit call to ``virDomainFSFreeze``
>+   since the guest agent then rejects any further freeze attempts once are
>+   filesystems frozen, an explicit freeze followed by a quiesced snapshot
>+   would fail and thaw filesystems.
>+
>+   Users are also encouraged to use ``virDomainFSFreeze/Thaw`` manually instead
>+   of relying on ``VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE`` if they need finer
>+   grained control.
>+
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano