[libvirt PATCH] docs: clarify how to build without -Werror

Ján Tomko via Devel posted 1 patch 5 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/42c99a068a589a8fdd38febbdf6d8e7371e3e45d.1750780132.git.jtomko@redhat.com
docs/compiling.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[libvirt PATCH] docs: clarify how to build without -Werror
Posted by Ján Tomko via Devel 5 months, 3 weeks ago
From: Ján Tomko <jtomko@redhat.com>

--werror does not accept any arguments for me and setting
git_werror was also needed to disable it with git.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 docs/compiling.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/compiling.rst b/docs/compiling.rst
index 0a47a50569..06a2d53c3a 100644
--- a/docs/compiling.rst
+++ b/docs/compiling.rst
@@ -105,8 +105,8 @@ Notes:
 ~~~~~~
 
 By default when the ``meson`` is run from within a GIT checkout, it will turn
-on -Werror for builds. This can be disabled with --werror=false, but this is
-not recommended.
+on -Werror for builds. This can be disabled with
+`-Dwerror=false -Dgit_werror=false`, but this is not recommended.
 
 Please ensure that you have the appropriate minimal ``meson`` version installed
 in your build environment. The minimal version for a specific package can be
-- 
2.49.0
Re: [libvirt PATCH] docs: clarify how to build without -Werror
Posted by Andrea Bolognani via Devel 5 months, 2 weeks ago
On Tue, Jun 24, 2025 at 05:48:52PM +0200, Ján Tomko via Devel wrote:
> +++ b/docs/compiling.rst
> @@ -105,8 +105,8 @@ Notes:
>  ~~~~~~
>
>  By default when the ``meson`` is run from within a GIT checkout, it will turn
> -on -Werror for builds. This can be disabled with --werror=false, but this is
> -not recommended.
> +on -Werror for builds. This can be disabled with
> +`-Dwerror=false -Dgit_werror=false`, but this is not recommended.

git_werror is a feature, not a boolean, so you need to use

  -Dgit_werror=disabled

instead. With that fixed

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization