qemu: fs: do not try to fill binary path if we have a socket

[libvirt PATCH] qemu: fs: do not try to fill binary path if we have a socket

Ján Tomko posted 1 patch 2 years, 11 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/41b359ef8fbe759a855938d2d73d3070df79a5fe.1621501833.git.jtomko@redhat.com

src/qemu/qemu_virtiofs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH] qemu: fs: do not try to fill binary path if we have a socket

Posted by Ján Tomko 2 years, 11 months ago

We do not need to look for a suitable binary in the vhost-user
description files, if we aren't the ones starting it.
Otherwise startup will fail with:

error: Failed to start domain 'vm1'
error: operation failed: Unable to find a satisfying virtiofsd

https://bugzilla.redhat.com/show_bug.cgi?id=1855789

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_virtiofs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c
index e310f2e7aa..edaedf0304 100644
--- a/src/qemu/qemu_virtiofs.c
+++ b/src/qemu/qemu_virtiofs.c
@@ -322,7 +322,7 @@ int
 qemuVirtioFSPrepareDomain(virQEMUDriver *driver,
                           virDomainFSDef *fs)
 {
-    if (fs->binary)
+    if (fs->binary || fs->sock)
         return 0;
 
     return qemuVhostUserFillDomainFS(driver, fs);
-- 
2.31.1

Re: [libvirt PATCH] qemu: fs: do not try to fill binary path if we have a socket

Posted by Michal Prívozník 2 years, 11 months ago

On 5/20/21 11:10 AM, Ján Tomko wrote:
> We do not need to look for a suitable binary in the vhost-user
> description files, if we aren't the ones starting it.
> Otherwise startup will fail with:
> 
> error: Failed to start domain 'vm1'
> error: operation failed: Unable to find a satisfying virtiofsd
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1855789
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_virtiofs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal