remote: remove leftover goto

[libvirt PATCH] remote: remove leftover goto

Ján Tomko posted 1 patch 3 years, 6 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/4040d6173117e0859c8d541f5c02a71a050b8a10.1602241739.git.jtomko@redhat.com

src/remote/remote_driver.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[libvirt PATCH] remote: remove leftover goto

Posted by Ján Tomko 3 years, 6 months ago

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reported-by: John Ferlan <jferlan@redhat.com>
Fixes: 8487595bee0c04e56b0d8e866c5c71318faf1689
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
/me gets the paper bag

 src/remote/remote_driver.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 49769ac04d..d318224605 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -7636,7 +7636,6 @@ remoteDomainGetFSInfo(virDomainPtr dom,
         }
 
         info_ret = g_new0(virDomainFSInfoPtr, ret.info.info_len);
-            goto cleanup;
 
         for (i = 0; i < ret.info.info_len; i++) {
             src = &ret.info.info_val[i];
-- 
2.26.2

Re: [libvirt PATCH] remote: remove leftover goto

Posted by John Ferlan 3 years, 6 months ago


On 10/9/20 7:09 AM, Ján Tomko wrote:
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> Reported-by: John Ferlan <jferlan@redhat.com>
> Fixes: 8487595bee0c04e56b0d8e866c5c71318faf1689
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
> /me gets the paper bag
> >  src/remote/remote_driver.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

Although you may want to clean up the double signoff

John