[libvirt] [libvirt-tck PATCH] conf: Upgrade the used version of fedora to 30

Erik Skultety posted 1 patch 4 years, 6 months ago
Failed in applying to current master (apply log)
conf/default.cfg | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
[libvirt] [libvirt-tck PATCH] conf: Upgrade the used version of fedora to 30
Posted by Erik Skultety 4 years, 6 months ago
Fedora 28 is already EOL and the URLs don't work anymore either because
EOL resources eventually move to
http://archives.fedoraproject.org/pub/archive/fedora/ from
https://dl.fedoraproject.org/pub/fedora/linux/releases/.
---

Notes:
    I'm wondering whether we shouldn't drop the secondary i686 sections as well
    since i686 will die starting with fedora 31. On a similar note with UML,
    upstream libvirt dropped it a while ago.

 conf/default.cfg | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/conf/default.cfg b/conf/default.cfg
index b97688e..d9fd0cb 100644
--- a/conf/default.cfg
+++ b/conf/default.cfg
@@ -49,7 +49,7 @@ images = (
       hvm
       xen
     )
-    osname = fedora-28
+    osname = fedora-30
   }
 )

@@ -75,25 +75,25 @@ images = (
 # empty sparse root FS will be created
 #
 kernels = (
-   # Fedora 28 i686 PAE has pv_ops, so one kernel can do both Xen and KVM guests here
+   # Fedora 30 i686 PAE has pv_ops, so one kernel can do both Xen and KVM guests here
    {
      arch = i686
      ostype = (
        hvm
        xen
      )
-     kernel = http://dl.fedoraproject.org/pub/fedora-secondary/releases/28/Everything/i386/os/images/pxeboot/vmlinuz
-     initrd = http://dl.fedoraproject.org/pub/fedora-secondary/releases/28/Everything/i386/os/images/pxeboot/initrd.img
+     kernel = http://dl.fedoraproject.org/pub/fedora-secondary/releases/30/Everything/i386/os/images/pxeboot/vmlinuz
+     initrd = http://dl.fedoraproject.org/pub/fedora-secondary/releases/30/Everything/i386/os/images/pxeboot/initrd.img
    }
-   # Fedora 28 x86_64 has pv_ops, so one kernel can do both Xen and KVM guests here
+   # Fedora 30 x86_64 has pv_ops, so one kernel can do both Xen and KVM guests here
    {
      arch = x86_64
      ostype = (
        hvm
        xen
      )
-     kernel = http://dl.fedoraproject.org/pub/fedora/linux/releases/28/Everything/x86_64/os/images/pxeboot/vmlinuz
-     initrd = http://dl.fedoraproject.org/pub/fedora/linux/releases/28/Everything/x86_64/os/images/pxeboot/initrd.img
+     kernel = http://dl.fedoraproject.org/pub/fedora/linux/releases/30/Everything/x86_64/os/images/pxeboot/vmlinuz
+     initrd = http://dl.fedoraproject.org/pub/fedora/linux/releases/30/Everything/x86_64/os/images/pxeboot/initrd.img
    }
    # User mode linux i686 needs custom kernel + root filesystem
    {
--
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-tck PATCH] conf: Upgrade the used version of fedora to 30
Posted by Fabiano Fidêncio 4 years, 6 months ago
On Tue, Sep 24, 2019 at 9:01 AM Erik Skultety <eskultet@redhat.com> wrote:
>
> Fedora 28 is already EOL and the URLs don't work anymore either because
> EOL resources eventually move to
> http://archives.fedoraproject.org/pub/archive/fedora/ from
> https://dl.fedoraproject.org/pub/fedora/linux/releases/.

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>

> ---
>
> Notes:
>     I'm wondering whether we shouldn't drop the secondary i686 sections as well
>     since i686 will die starting with fedora 31. On a similar note with UML,
>     upstream libvirt dropped it a while ago.

I'd drop i686 sections when Fedora 31 is out. About the UML, is this
release already part of Fedora 30? If so, drop it. If not, drop when a
release reaches the Fedora used here.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-tck PATCH] conf: Upgrade the used version of fedora to 30
Posted by Erik Skultety 4 years, 6 months ago
On Tue, Sep 24, 2019 at 09:19:19AM +0200, Fabiano Fidêncio wrote:
> On Tue, Sep 24, 2019 at 9:01 AM Erik Skultety <eskultet@redhat.com> wrote:
> >
> > Fedora 28 is already EOL and the URLs don't work anymore either because
> > EOL resources eventually move to
> > http://archives.fedoraproject.org/pub/archive/fedora/ from
> > https://dl.fedoraproject.org/pub/fedora/linux/releases/.
>
> Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
>
> > ---
> >
> > Notes:
> >     I'm wondering whether we shouldn't drop the secondary i686 sections as well
> >     since i686 will die starting with fedora 31. On a similar note with UML,
> >     upstream libvirt dropped it a while ago.
>
> I'd drop i686 sections when Fedora 31 is out. About the UML, is this
> release already part of Fedora 30? If so, drop it. If not, drop when a
> release reaches the Fedora used here.

Okay, I'll post a separate patch for the UML part, we dropped the driver in
v5.0.0 (commit 29682196), Fedora 30 contains v5.1.0.

Thanks,
Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-tck PATCH] conf: Upgrade the used version of fedora to 30
Posted by Laine Stump 4 years, 6 months ago
On 9/24/19 2:59 AM, Erik Skultety wrote:
> Fedora 28 is already EOL and the URLs don't work anymore either because
> EOL resources eventually move to
> http://archives.fedoraproject.org/pub/archive/fedora/ from
> https://dl.fedoraproject.org/pub/fedora/linux/releases/.


Hah! I made this same patch locally (even though I didn't see the error, 
since I already had an F28 image cached) after I tried out your other 
patch yesterday, but hadn't gotten around to sending it. I see Fidencio 
already ACKed, so I won't bother...


(Personal note: I'm still running an F27 image downloaded by 
virt-builder for libvirt-tck for some simple test images. I don't know 
that I'll ever replace it until/unless something breaks :-)


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list