util: virstring: Remove unused prototypes for virStr(n)dup

[PATCH] util: virstring: Remove unused prototypes for virStr(n)dup

Peter Krempa posted 1 patch 3 years, 2 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/3ea190ee7805606458a353f6ea9b29dc1b177d37.1612187535.git.pkrempa@redhat.com

src/util/virstring.h | 7 -------
1 file changed, 7 deletions(-)

Expand all Fold all

[PATCH] util: virstring: Remove unused prototypes for virStr(n)dup

Posted by Peter Krempa 3 years, 2 months ago

The headers weren't removed after use of VIR_STRDUP was removed.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/util/virstring.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/util/virstring.h b/src/util/virstring.h
index 55547b040a..cfd24f0b74 100644
--- a/src/util/virstring.h
+++ b/src/util/virstring.h
@@ -123,13 +123,6 @@ int virStrcpy(char *dest, const char *src, size_t destbytes)
     G_GNUC_WARN_UNUSED_RESULT;
 #define virStrcpyStatic(dest, src) virStrcpy((dest), (src), sizeof(dest))

-/* Don't call these directly - use the macros below */
-int virStrdup(char **dest, const char *src)
-    G_GNUC_WARN_UNUSED_RESULT ATTRIBUTE_NONNULL(1);
-
-int virStrndup(char **dest, const char *src, ssize_t n)
-    G_GNUC_WARN_UNUSED_RESULT ATTRIBUTE_NONNULL(1);
-
 size_t virStringListLength(const char * const *strings);

 int virStringSortCompare(const void *a, const void *b);
-- 
2.29.2

Re: [PATCH] util: virstring: Remove unused prototypes for virStr(n)dup

Posted by Daniel P. Berrangé 3 years, 2 months ago

On Mon, Feb 01, 2021 at 02:52:15PM +0100, Peter Krempa wrote:
> The headers weren't removed after use of VIR_STRDUP was removed.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/util/virstring.h | 7 -------
>  1 file changed, 7 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|