[libvirt] [PATCH] news: Add the qemu VM reconnect segfault fix into bugfixes section

Erik Skultety posted 1 patch 19 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/3e3e3e53205573ef1c2cbde5a08448f3f181ab6d.1528458156.git.eskultet@redhat.com
Test syntax-check passed
docs/news.xml | 11 +++++++++++
1 file changed, 11 insertions(+)

[libvirt] [PATCH] news: Add the qemu VM reconnect segfault fix into bugfixes section

Posted by Erik Skultety 19 weeks ago
Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
This is IMHO worth mentioning in the news as it might be forgotten with our
monthly "late news" update right before the release.

 docs/news.xml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index e0cf381f33..13001cee5b 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -73,6 +73,17 @@
       </change>
     </section>
     <section title="Bug fixes">
+      <change>
+        <summary>
+          qemu: Fix a potential segmentation fault on VM reconnect
+        </summary>
+        <description>
+          Initialization of the driver worker pool needs to come before libvirtd
+          trying to reconnect to all machines, since one of the QEMU processes
+          migh have already emitted events which need to be handled prior to
+          us getting to the worker pool initialization.
+        </description>
+      </change>
     </section>
   </release>
   <release version="v4.4.0" date="2018-06-04">
--
2.14.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] news: Add the qemu VM reconnect segfault fix into bugfixes section

Posted by Peter Krempa 19 weeks ago
On Fri, Jun 08, 2018 at 13:44:45 +0200, Erik Skultety wrote:
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
> This is IMHO worth mentioning in the news as it might be forgotten with our
> monthly "late news" update right before the release.
> 
>  docs/news.xml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index e0cf381f33..13001cee5b 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -73,6 +73,17 @@
>        </change>
>      </section>
>      <section title="Bug fixes">
> +      <change>
> +        <summary>
> +          qemu: Fix a potential segmentation fault on VM reconnect

s/segmentation fault/crash of libvirtd/


> +        </summary>
> +        <description>
> +          Initialization of the driver worker pool needs to come before libvirtd
> +          trying to reconnect to all machines, since one of the QEMU processes
> +          migh have already emitted events which need to be handled prior to
> +          us getting to the worker pool initialization.
> +        </description>
> +      </change>
>      </section>
>    </release>
>    <release version="v4.4.0" date="2018-06-04">

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] news: Add the qemu VM reconnect segfault fix into bugfixes section

Posted by Andrea Bolognani 19 weeks ago
On Fri, 2018-06-08 at 13:44 +0200, Erik Skultety wrote:
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
> This is IMHO worth mentioning in the news as it might be forgotten with our
> monthly "late news" update right before the release.

Note that such last-minute updates are *not* the way release notes
are supposed to be handled: what you're doing here is. So, thanks
for taking care of it at the appropriate[1] time!


[1] Well, ideally release notes updates would be sent out along
    with the changes they're documenting, but this is close
    enough ;)
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list