[PATCH] qemu_monitor: Document qemuMonitorUnregister()

Michal Privoznik posted 1 patch 3 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/3bfcb4eaa6200c6db7e85abc96b4a8b1f45b3486.1614175460.git.mprivozn@redhat.com
src/qemu/qemu_monitor.c | 7 +++++++
1 file changed, 7 insertions(+)
[PATCH] qemu_monitor: Document qemuMonitorUnregister()
Posted by Michal Privoznik 3 years, 2 months ago
The most important bit is that the caller is expected to pass
locked monitor.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_monitor.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index ed35da17e1..73f337a6be 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -850,6 +850,13 @@ qemuMonitorRegister(qemuMonitorPtr mon)
 }
 
 
+/**
+ * qemuMonitorUnregister:
+ * @mon: monitor object
+ *
+ * Unregister monitor from the event loop. The monitor object
+ * must be locked before calling this function.
+ */
 void
 qemuMonitorUnregister(qemuMonitorPtr mon)
 {
-- 
2.26.2

Re: [PATCH] qemu_monitor: Document qemuMonitorUnregister()
Posted by Andrea Bolognani 3 years, 2 months ago
On Wed, 2021-02-24 at 15:04 +0100, Michal Privoznik wrote:
> The most important bit is that the caller is expected to pass
> locked monitor.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/qemu/qemu_monitor.c | 7 +++++++
>  1 file changed, 7 insertions(+)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization