[libvirt] [PATCH] xen: Remove unused 'cfg'

Peter Krempa posted 1 patch 4 years, 4 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/35614b6022244b8ccb04b0c7aff3b7cd32ff418a.1575896805.git.pkrempa@redhat.com
src/libxl/libxl_domain.c | 1 -
tests/xlconfigtest.c     | 1 -
tests/xmconfigtest.c     | 1 -
3 files changed, 3 deletions(-)
[libvirt] [PATCH] xen: Remove unused 'cfg'
Posted by Peter Krempa 4 years, 4 months ago
Refactoring of the XML parser left few instances of the
libxlDriverConfig object unused. Remove them.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---

Pushed under the build-breaker rule as it makes clang unhappy.

 src/libxl/libxl_domain.c | 1 -
 tests/xlconfigtest.c     | 1 -
 tests/xmconfigtest.c     | 1 -
 3 files changed, 3 deletions(-)

diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index ff9502d3bb..915aaeb8b0 100644
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -1547,7 +1547,6 @@ libxlDomainDefCheckABIStability(libxlDriverPrivatePtr driver,
 {
     virDomainDefPtr migratableDefSrc = NULL;
     virDomainDefPtr migratableDefDst = NULL;
-    g_autoptr(libxlDriverConfig) cfg = libxlDriverConfigGet(driver);
     bool ret = false;

     if (!(migratableDefSrc = virDomainDefCopy(src, driver->xmlopt, NULL, true)) ||
diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c
index 3c0469be85..4e4b28cd34 100644
--- a/tests/xlconfigtest.c
+++ b/tests/xlconfigtest.c
@@ -72,7 +72,6 @@ testCompareParseXML(const char *xlcfg, const char *xml, bool replaceVars)
     int ret = -1;
     virDomainDefPtr def = NULL;
     char *replacedXML = NULL;
-    g_autoptr(libxlDriverConfig) cfg = libxlDriverConfigGet(driver);

     if (VIR_ALLOC_N(gotxlcfgData, wrote) < 0)
         goto fail;
diff --git a/tests/xmconfigtest.c b/tests/xmconfigtest.c
index 7e324eb5d2..6bd18d0fe1 100644
--- a/tests/xmconfigtest.c
+++ b/tests/xmconfigtest.c
@@ -45,7 +45,6 @@ testCompareParseXML(const char *xmcfg, const char *xml)
     virConnectPtr conn = NULL;
     int wrote = 4096;
     virDomainDefPtr def = NULL;
-    g_autoptr(libxlDriverConfig) cfg = libxlDriverConfigGet(driver);

     if (VIR_ALLOC_N(gotxmcfgData, wrote) < 0)
         goto fail;
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list