bhyve_conf: Drop unused 'error' label in virBhyveDriverConfigNew()

[libvirt] [PATCH] bhyve_conf: Drop unused 'error' label in virBhyveDriverConfigNew()

Michal Privoznik posted 1 patch 4 years, 6 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/3357500af2752a974093a5ea5c00e43e1d2b8b34.1571727231.git.mprivozn@redhat.com

src/bhyve/bhyve_conf.c | 4 ----
1 file changed, 4 deletions(-)

Expand all Fold all

[libvirt] [PATCH] bhyve_conf: Drop unused 'error' label in virBhyveDriverConfigNew()

Posted by Michal Privoznik 4 years, 6 months ago

There's unused 'error' label left after transition from
VIR_STRDUP() to g_strdup (v5.8.0-255-g652cdbe364).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

Pushed under trivial & build breaker rules.

 src/bhyve/bhyve_conf.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/bhyve/bhyve_conf.c b/src/bhyve/bhyve_conf.c
index ab5d7f467b..f3e2ebf7c7 100644
--- a/src/bhyve/bhyve_conf.c
+++ b/src/bhyve/bhyve_conf.c
@@ -59,10 +59,6 @@ virBhyveDriverConfigNew(void)
     cfg->firmwareDir = g_strdup(DATADIR "/uefi-firmware");
 
     return cfg;
-
- error:
-    virObjectUnref(cfg);
-    return NULL;
 }
 
 int
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] bhyve_conf: Drop unused 'error' label in virBhyveDriverConfigNew()

Posted by Ján Tomko 4 years, 6 months ago

On Tue, Oct 22, 2019 at 08:54:10AM +0200, Michal Privoznik wrote:
>There's unused 'error' label left after transition from
>VIR_STRDUP() to g_strdup (v5.8.0-255-g652cdbe364).
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
>
>Pushed under trivial & build breaker rules.
>
> src/bhyve/bhyve_conf.c | 4 ----
> 1 file changed, 4 deletions(-)
>

Thanked-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list