Allow virConnect.getDomainCapabilities() to have no arguments

[libvirt] [python PATCH] Allow virConnect.getDomainCapabilities() to have no arguments

Posted by Michal Privoznik 4 years, 12 months ago

Our C API allows no values to be passed (well, it accepts all
NULLs). There's no reason that python binding should require all
arguments.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 libvirt-override-api.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/libvirt-override-api.xml b/libvirt-override-api.xml
index 7f578e0..53b15c5 100644
--- a/libvirt-override-api.xml
+++ b/libvirt-override-api.xml
@@ -754,5 +754,15 @@
       <arg name='conn' type='virConnectPtr' info='pointer to hypervisor connection'/>
       <arg name='flags' type='int' info='unused, always pass 0'/>
     </function>
+    <function name='virConnectGetDomainCapabilities' file='libvirt-domain' module='libvirt-domain'>
+      <info>Query domain capabilities</info>
+      <return type='char *' info='NULL in case of error or an XML string defining the capabilities.'/>
+      <arg name='conn' type='virConnectPtr' info='pointer to the hypervisor connection'/>
+      <arg name='emulatorbin' type='const char *' info='optional path to emulator'/>
+      <arg name='arch' type='const char *' info='optional domain architecture'/>
+      <arg name='machine' type='const char *' info='optional machine type'/>
+      <arg name='virttype' type='const char *' info='optional virtualization type'/>
+      <arg name='flags' type='int' info='unused, always pass 0'/>
+    </function>
   </symbols>
 </api>
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [python PATCH] Allow virConnect.getDomainCapabilities() to have no arguments

Posted by Kashyap Chamarthy 4 years, 12 months ago

On Fri, Apr 26, 2019 at 02:07:30PM +0200, Michal Privoznik wrote:
> Our C API allows no values to be passed (well, it accepts all
> NULLs). There's no reason that python binding should require all
> arguments.

Thanks for the quick fix.

> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  libvirt-override-api.xml | 10 ++++++++++
>  1 file changed, 10 insertions(+)

FWIW:

    Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com>

> diff --git a/libvirt-override-api.xml b/libvirt-override-api.xml
> index 7f578e0..53b15c5 100644
> --- a/libvirt-override-api.xml
> +++ b/libvirt-override-api.xml
> @@ -754,5 +754,15 @@
>        <arg name='conn' type='virConnectPtr' info='pointer to hypervisor connection'/>
>        <arg name='flags' type='int' info='unused, always pass 0'/>
>      </function>
> +    <function name='virConnectGetDomainCapabilities' file='libvirt-domain' module='libvirt-domain'>
> +      <info>Query domain capabilities</info>
> +      <return type='char *' info='NULL in case of error or an XML string defining the capabilities.'/>
> +      <arg name='conn' type='virConnectPtr' info='pointer to the hypervisor connection'/>
> +      <arg name='emulatorbin' type='const char *' info='optional path to emulator'/>
> +      <arg name='arch' type='const char *' info='optional domain architecture'/>
> +      <arg name='machine' type='const char *' info='optional machine type'/>
> +      <arg name='virttype' type='const char *' info='optional virtualization type'/>
> +      <arg name='flags' type='int' info='unused, always pass 0'/>
> +    </function>
>    </symbols>
>  </api>
> -- 
> 2.21.0
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

-- 
/kashyap

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list