virConnectGetAllDomainStats: Document two vcpu stats

[PATCH] virConnectGetAllDomainStats: Document two vcpu stats

Michal Privoznik posted 1 patch 3 years, 10 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/310dd400097db88fc8709128d25e2a9f77c6d3c4.1593441781.git.mprivozn@redhat.com

src/libvirt-domain.c | 5 +++++
1 file changed, 5 insertions(+)

Expand all Fold all

[PATCH] virConnectGetAllDomainStats: Document two vcpu stats

Posted by Michal Privoznik 3 years, 10 months ago

When introducing vcpu.<num>.wait (v1.3.2-rc1~301) and
vcpu.<num>.halted (v2.4.0-rc1~36) the documentation was
not written.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/libvirt-domain.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 60b5e65fc3..52ce3ef798 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -11493,6 +11493,11 @@ virConnectGetDomainCapabilities(virConnectPtr conn,
  *                          from virVcpuState enum.
  *     "vcpu.<num>.time" - virtual cpu time spent by virtual CPU <num>
  *                         as unsigned long long.
+ *     "vcpu.<num>.wait" - time the vCPU <num> wants to run, but the host
+ *                         scheduler has something else running ahead of it.
+ *     "vcpu.<num>.halted" - virtual CPU <num> is halted, may indicate the
+ *                           processor is idle or even disabled, depending
+ *                           on the architecture)
  *
  * VIR_DOMAIN_STATS_INTERFACE:
  *     Return network interface statistics (from domain point of view).
-- 
2.26.2

Re: [PATCH] virConnectGetAllDomainStats: Document two vcpu stats

Posted by Erik Skultety 3 years, 10 months ago

On Mon, Jun 29, 2020 at 04:43:09PM +0200, Michal Privoznik wrote:
> When introducing vcpu.<num>.wait (v1.3.2-rc1~301) and
> vcpu.<num>.halted (v2.4.0-rc1~36) the documentation was
> not written.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>