cpu_map: Fix spelling of svme-addr-chk feature

[libvirt PATCH] cpu_map: Fix spelling of svme-addr-chk feature

Posted by Jiri Denemark 3 years, 1 month ago

Commit a208176ca1d9eedf8aa6bf12fde6a7a9579ab549 introduced this feature
with an incorrect "svme-addr-check" spelling.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/cpu_map/sync_qemu_i386.py  | 2 +-
 src/cpu_map/x86_EPYC-Milan.xml | 2 +-
 src/cpu_map/x86_features.xml   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py
index 3febecdfd1..1a98fa70d7 100755
--- a/src/cpu_map/sync_qemu_i386.py
+++ b/src/cpu_map/sync_qemu_i386.py
@@ -142,7 +142,7 @@ def translate_feature(name):
         "CPUID_SS": "ss",
         "CPUID_SVM_NPT": "npt",
         "CPUID_SVM_NRIPSAVE": "nrip-save",
-        "CPUID_SVM_SVME_ADDR_CHK": "svme-addr-check",
+        "CPUID_SVM_SVME_ADDR_CHK": "svme-addr-chk",
         "CPUID_TSC": "tsc",
         "CPUID_VME": "vme",
         "CPUID_XSAVE_XGETBV1": "xgetbv1",
diff --git a/src/cpu_map/x86_EPYC-Milan.xml b/src/cpu_map/x86_EPYC-Milan.xml
index 53f0cd6aac..3055e175fa 100644
--- a/src/cpu_map/x86_EPYC-Milan.xml
+++ b/src/cpu_map/x86_EPYC-Milan.xml
@@ -76,7 +76,7 @@
     <feature name='sse4a'/>
     <feature name='ssse3'/>
     <feature name='svm'/>
-    <feature name='svme-addr-check'/>
+    <feature name='svme-addr-chk'/>
     <feature name='syscall'/>
     <feature name='tsc'/>
     <feature name='umip'/>
diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml
index c43520d08f..e98b84f3ef 100644
--- a/src/cpu_map/x86_features.xml
+++ b/src/cpu_map/x86_features.xml
@@ -554,7 +554,7 @@
   <feature name='pfthreshold'>
     <cpuid eax_in='0x8000000a' edx='0x00001000'/>
   </feature>
-  <feature name='svme-addr-check'>
+  <feature name='svme-addr-chk'>
     <cpuid eax_in='0x8000000a' edx='0x10000000'/>
   </feature>
 
-- 
2.30.0

Re: [libvirt PATCH] cpu_map: Fix spelling of svme-addr-chk feature

Posted by Tim Wiederhake 3 years, 1 month ago

On Thu, 2021-03-04 at 08:44 +0100, Jiri Denemark wrote:
> Commit a208176ca1d9eedf8aa6bf12fde6a7a9579ab549 introduced this
> feature
> with an incorrect "svme-addr-check" spelling.
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>

My bad.

Reviewed-by: Tim Wiederhake <twiederh@redhat.com>

> ---
>  src/cpu_map/sync_qemu_i386.py  | 2 +-
>  src/cpu_map/x86_EPYC-Milan.xml | 2 +-
>  src/cpu_map/x86_features.xml   | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/cpu_map/sync_qemu_i386.py
> b/src/cpu_map/sync_qemu_i386.py
> index 3febecdfd1..1a98fa70d7 100755
> --- a/src/cpu_map/sync_qemu_i386.py
> +++ b/src/cpu_map/sync_qemu_i386.py
> @@ -142,7 +142,7 @@ def translate_feature(name):
>          "CPUID_SS": "ss",
>          "CPUID_SVM_NPT": "npt",
>          "CPUID_SVM_NRIPSAVE": "nrip-save",
> -        "CPUID_SVM_SVME_ADDR_CHK": "svme-addr-check",
> +        "CPUID_SVM_SVME_ADDR_CHK": "svme-addr-chk",
>          "CPUID_TSC": "tsc",
>          "CPUID_VME": "vme",
>          "CPUID_XSAVE_XGETBV1": "xgetbv1",
> diff --git a/src/cpu_map/x86_EPYC-Milan.xml b/src/cpu_map/x86_EPYC-
> Milan.xml
> index 53f0cd6aac..3055e175fa 100644
> --- a/src/cpu_map/x86_EPYC-Milan.xml
> +++ b/src/cpu_map/x86_EPYC-Milan.xml
> @@ -76,7 +76,7 @@
>      <feature name='sse4a'/>
>      <feature name='ssse3'/>
>      <feature name='svm'/>
> -    <feature name='svme-addr-check'/>
> +    <feature name='svme-addr-chk'/>
>      <feature name='syscall'/>
>      <feature name='tsc'/>
>      <feature name='umip'/>
> diff --git a/src/cpu_map/x86_features.xml
> b/src/cpu_map/x86_features.xml
> index c43520d08f..e98b84f3ef 100644
> --- a/src/cpu_map/x86_features.xml
> +++ b/src/cpu_map/x86_features.xml
> @@ -554,7 +554,7 @@
>    <feature name='pfthreshold'>
>      <cpuid eax_in='0x8000000a' edx='0x00001000'/>
>    </feature>
> -  <feature name='svme-addr-check'>
> +  <feature name='svme-addr-chk'>
>      <cpuid eax_in='0x8000000a' edx='0x10000000'/>
>    </feature>
>