qemuDomainGetStatsCpuProc: Use string constants for CPU stats

[PATCH] qemuDomainGetStatsCpuProc: Use string constants for CPU stats

Peter Krempa via Devel posted 1 patch 2 weeks, 3 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/29e268deca4b7cc5451416381c84c92f054a5165.1759938121.git.pkrempa@redhat.com

src/qemu/qemu_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH] qemuDomainGetStatsCpuProc: Use string constants for CPU stats

Posted by Peter Krempa via Devel 2 weeks, 3 days ago

From: Peter Krempa <pkrempa@redhat.com>

Commit 947306957e9 added the constants and fixed other uses but didn't
fix qemuDomainGetStatsCpuProc.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_driver.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index ac72ea5cb0..d26c8997bf 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17054,9 +17054,9 @@ qemuDomainGetStatsCpuProc(virDomainObj *vm,
         return;
     }

-    virTypedParamListAddULLong(params, cpuTime, "cpu.time");
-    virTypedParamListAddULLong(params, userTime, "cpu.user");
-    virTypedParamListAddULLong(params, sysTime, "cpu.system");
+    virTypedParamListAddULLong(params, cpuTime, VIR_DOMAIN_STATS_CPU_TIME);
+    virTypedParamListAddULLong(params, userTime, VIR_DOMAIN_STATS_CPU_USER);
+    virTypedParamListAddULLong(params, sysTime, VIR_DOMAIN_STATS_CPU_SYSTEM);
 }


-- 
2.51.0

Re: [PATCH] qemuDomainGetStatsCpuProc: Use string constants for CPU stats

Posted by Pavel Hrdina via Devel 2 weeks, 3 days ago

On Wed, Oct 08, 2025 at 05:42:01PM +0200, Peter Krempa via Devel wrote:
> From: Peter Krempa <pkrempa@redhat.com>
> 
> Commit 947306957e9 added the constants and fixed other uses but didn't
> fix qemuDomainGetStatsCpuProc.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/qemu/qemu_driver.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>