meson: Don't check for addr2line

[PATCH] meson: Don't check for addr2line

Michal Privoznik posted 1 patch 3 years, 1 month ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/284e6f43494ed8eb736d9e68843ccd0f8d688ec4.1615829435.git.mprivozn@redhat.com

meson.build | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] meson: Don't check for addr2line

Posted by Michal Privoznik 3 years, 1 month ago

In the past, we used to have this oomtrace.pl script that
attempted to print the stack trace of where an OOM error
occurred and it used addr2line for that. But since v5.8.0-rc1~189
we don't really care about OOM anymore and the script is long
gone so there's no need to check for addr2line program either.

Fixes: 2c52ecd96086b4643b99b4570b5823d40ce2787b
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meson.build b/meson.build
index c81c6ab205..69a7b4c88e 100644
--- a/meson.build
+++ b/meson.build
@@ -925,7 +925,6 @@ endforeach
 # optional programs
 
 optional_programs = [
-  'addr2line',
   'augparse',
   'dmidecode',
   'dnsmasq',
-- 
2.26.2

Re: [PATCH] meson: Don't check for addr2line

Posted by Pavel Hrdina 3 years, 1 month ago

On Mon, Mar 15, 2021 at 06:30:42PM +0100, Michal Privoznik wrote:
> In the past, we used to have this oomtrace.pl script that
> attempted to print the stack trace of where an OOM error
> occurred and it used addr2line for that. But since v5.8.0-rc1~189
> we don't really care about OOM anymore and the script is long
> gone so there's no need to check for addr2line program either.
> 
> Fixes: 2c52ecd96086b4643b99b4570b5823d40ce2787b
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  meson.build | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>