[PATCH] esx_util: Drop extra spacing

Michal Privoznik via Devel posted 1 patch 3 weeks, 3 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/27fa9c21daa60cd42c09f9008f27c7d335cd30a7.1767884683.git.mprivozn@redhat.com
src/esx/esx_util.c | 10 ----------
1 file changed, 10 deletions(-)
[PATCH] esx_util: Drop extra spacing
Posted by Michal Privoznik via Devel 3 weeks, 3 days ago
From: Michal Privoznik <mprivozn@redhat.com>

Per our coding style, function shall be separated by either a
single line or two lines. But in esx_util.c functions are
separated by three or even four blank lines. Drop excessive
spacing.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/esx/esx_util.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/esx/esx_util.c b/src/esx/esx_util.c
index 9b714d90ba..88b3dc893f 100644
--- a/src/esx/esx_util.c
+++ b/src/esx/esx_util.c
@@ -159,8 +159,6 @@ esxUtil_ParseUri(esxUtil_ParsedUri **parsedUri, virURI *uri)
 }
 
 
-
-
 void
 esxUtil_FreeParsedUri(esxUtil_ParsedUri **parsedUri)
 {
@@ -177,7 +175,6 @@ esxUtil_FreeParsedUri(esxUtil_ParsedUri **parsedUri)
 }
 
 
-
 int
 esxUtil_ParseVirtualMachineIDString(const char *id_string, int *id)
 {
@@ -198,7 +195,6 @@ esxUtil_ParseVirtualMachineIDString(const char *id_string, int *id)
 }
 
 
-
 int
 esxUtil_ParseDatastorePath(const char *datastorePath, char **datastoreName,
                            char **directoryName, char **directoryAndFileName)
@@ -271,7 +267,6 @@ esxUtil_ParseDatastorePath(const char *datastorePath, char **datastoreName,
 }
 
 
-
 int
 esxUtil_ResolveHostname(const char *hostname, char **ipAddress)
 {
@@ -319,7 +314,6 @@ esxUtil_ResolveHostname(const char *hostname, char **ipAddress)
 }
 
 
-
 int
 esxUtil_ReformatUuid(const char *input, char *output)
 {
@@ -338,7 +332,6 @@ esxUtil_ReformatUuid(const char *input, char *output)
 }
 
 
-
 char *
 esxUtil_EscapeBase64(const char *string)
 {
@@ -394,7 +387,6 @@ esxUtil_EscapeBase64(const char *string)
 }
 
 
-
 void
 esxUtil_ReplaceSpecialWindowsPathChars(char *string)
 {
@@ -418,7 +410,6 @@ esxUtil_ReplaceSpecialWindowsPathChars(char *string)
 }
 
 
-
 char *
 esxUtil_EscapeDatastoreItem(const char *string)
 {
@@ -438,7 +429,6 @@ esxUtil_EscapeDatastoreItem(const char *string)
 }
 
 
-
 char *
 esxUtil_EscapeForXml(const char *string)
 {
-- 
2.52.0
Re: [PATCH] esx_util: Drop extra spacing
Posted by Jiri Denemark via Devel 3 weeks, 3 days ago
On Thu, Jan 08, 2026 at 16:04:43 +0100, Michal Privoznik wrote:
> From: Michal Privoznik <mprivozn@redhat.com>
> 
> Per our coding style, function shall be separated by either a
> single line or two lines. But in esx_util.c functions are
> separated by three or even four blank lines. Drop excessive
> spacing.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/esx/esx_util.c | 10 ----------
>  1 file changed, 10 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>