[libvirt] [PATCH] spec: Remove libvirt < 0.9.4 upgrade compat

Cole Robinson posted 1 patch 4 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/261ffe18437c8c395559703115e7c0fd88d6315c.1552938388.git.crobinso@redhat.com
libvirt.spec.in | 19 -------------------
1 file changed, 19 deletions(-)

[libvirt] [PATCH] spec: Remove libvirt < 0.9.4 upgrade compat

Posted by Cole Robinson 4 weeks ago
These blocks are only triggered when updating from a libvirt version
less than 0.9.4, which was released in august 2011. I think it's been
long enough that we can say this upgrade path is unsupported without
an intermediate step

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 libvirt.spec.in | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 1497cad3d2..dd725baf24 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1444,16 +1444,6 @@ fi
 rm -rf %{_localstatedir}/lib/rpm-state/libvirt || :
 
 
-%triggerun -- libvirt < 0.9.4
-%{_bindir}/systemd-sysv-convert --save libvirtd >/dev/null 2>&1 ||:
-
-# If the package is allowed to autostart:
-/bin/systemctl --no-reload enable libvirtd.service >/dev/null 2>&1 ||:
-
-# Run these because the SysV package being removed won't do them
-/sbin/chkconfig --del libvirtd >/dev/null 2>&1 || :
-/bin/systemctl try-restart libvirtd.service >/dev/null 2>&1 || :
-
 %if %{with_qemu}
 %pre daemon-driver-qemu
 # We want soft static allocation of well-known ids, as disk images
@@ -1485,15 +1475,6 @@ exit 0
 /sbin/ldconfig
 %systemd_postun libvirt-guests.service
 
-%triggerun client -- libvirt < 0.9.4
-%{_bindir}/systemd-sysv-convert --save libvirt-guests >/dev/null 2>&1 ||:
-
-# If the package is allowed to autostart:
-/bin/systemctl --no-reload enable libvirt-guests.service >/dev/null 2>&1 ||:
-
-# Run this because the SysV package being removed won't do them
-/sbin/chkconfig --del libvirt-guests >/dev/null 2>&1 || :
-
 %if %{with_sanlock}
 %post lock-sanlock
 if getent group sanlock > /dev/null ; then
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Remove libvirt < 0.9.4 upgrade compat

Posted by Andrea Bolognani 4 weeks ago
On Mon, 2019-03-18 at 15:46 -0400, Cole Robinson wrote:
> These blocks are only triggered when updating from a libvirt version
> less than 0.9.4, which was released in august 2011. I think it's been

s/august/August/

> long enough that we can say this upgrade path is unsupported without
> an intermediate step

Missing period at the end of the sentence.

[...]
> +++ b/libvirt.spec.in
> @@ -1444,16 +1444,6 @@ fi
>  rm -rf %{_localstatedir}/lib/rpm-state/libvirt || :
>  
>  

You can drop an extra empty line here.


I believe these changes are safe, so

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

Please leave the patch on the list a few days before pushing,
though, in order to give other developers a fair opportunity to
raise any concerns they might have.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list