Add details for shutdown event

[libvirt] [libvirt-python PATCH] Add details for shutdown event

Posted by Martin Kletzander 6 years, 10 months ago

In commit a8eba5036cb4b0e2ec827e9e6e019ce70e451377, libvirt added
support for two more details.  Follow that in python bindings as well.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1463188

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 examples/event-test.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/event-test.py b/examples/event-test.py
index 3bca9e27c9be..4eb71425cff4 100755
--- a/examples/event-test.py
+++ b/examples/event-test.py
@@ -477,7 +477,7 @@ def domDetailToString(event, detail):
         ( "Paused", "Migrated", "IOError", "Watchdog", "Restored", "Snapshot", "API error" ),
         ( "Unpaused", "Migrated", "Snapshot" ),
         ( "Shutdown", "Destroyed", "Crashed", "Migrated", "Saved", "Failed", "Snapshot"),
-        ( "Finished", ),
+        ( "Finished", "On guest request", "On host request"),
         ( "Memory", "Disk" ),
         ( "Panicked", ),
         )
-- 
2.13.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-python PATCH] Add details for shutdown event

Posted by Peter Krempa 6 years, 10 months ago

On Tue, Jun 20, 2017 at 16:21:34 +0200, Martin Kletzander wrote:
> In commit a8eba5036cb4b0e2ec827e9e6e019ce70e451377, libvirt added
> support for two more details.  Follow that in python bindings as well.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1463188
> 
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
>  examples/event-test.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/event-test.py b/examples/event-test.py
> index 3bca9e27c9be..4eb71425cff4 100755
> --- a/examples/event-test.py
> +++ b/examples/event-test.py
> @@ -477,7 +477,7 @@ def domDetailToString(event, detail):
>          ( "Paused", "Migrated", "IOError", "Watchdog", "Restored", "Snapshot", "API error" ),
>          ( "Unpaused", "Migrated", "Snapshot" ),
>          ( "Shutdown", "Destroyed", "Crashed", "Migrated", "Saved", "Failed", "Snapshot"),
> -        ( "Finished", ),
> +        ( "Finished", "On guest request", "On host request"),
>          ( "Memory", "Disk" ),
>          ( "Panicked", ),
>          )

ACK if you mention in the commit message that only the test/example file
was wrong. 
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list