spec: Update version check for maint Source URL

[libvirt] [PATCH] spec: Update version check for maint Source URL

Posted by Cole Robinson 6 years, 11 months ago

New maint release version numbers of just A.B.C format, not the old
A.B.C.D format. Adjust the check that dynamically changes the Source
URL for maint releases
---
 libvirt.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index b249224..734b187 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -233,7 +233,7 @@ Group: Development/Libraries
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root
 URL: http://libvirt.org/
 
-%if %(echo %{version} | grep -o \\. | wc -l) == 3
+%if %(echo %{version} | grep -q "\.0$"; echo $?) == 1
     %define mainturl stable_updates/
 %endif
 Source: http://libvirt.org/sources/%{?mainturl}libvirt-%{version}.tar.xz
-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Update version check for maint Source URL

Posted by Andrea Bolognani 6 years, 11 months ago

On Thu, 2017-05-04 at 20:08 -0400, Cole Robinson wrote:
> New maint release version numbers of just A.B.C format, not the old
> A.B.C.D format. Adjust the check that dynamically changes the Source
> URL for maint releases
> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Update version check for maint Source URL

Posted by Andrea Bolognani 6 years, 11 months ago

On Thu, 2017-05-04 at 20:08 -0400, Cole Robinson wrote:
> New maint release version numbers of just A.B.C format, not the old
> A.B.C.D format. Adjust the check that dynamically changes the Source
> URL for maint releases
> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

By the way, the machinery to deal with mainteinance release
is missing altogether from mingw-libvirt.spec.in, shouldn't
we add it there as well?

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Update version check for maint Source URL

Posted by Cole Robinson 6 years, 11 months ago

On 05/09/2017 11:57 AM, Andrea Bolognani wrote:
> On Thu, 2017-05-04 at 20:08 -0400, Cole Robinson wrote:
>> New maint release version numbers of just A.B.C format, not the old
>> A.B.C.D format. Adjust the check that dynamically changes the Source
>> URL for maint releases
>> ---
>>   libvirt.spec.in | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> By the way, the machinery to deal with mainteinance release
> is missing altogether from mingw-libvirt.spec.in, shouldn't
> we add it there as well?

Yes I think so, I've just never done a mingw build so didn't consider it

Thanks,
Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list