[libvirt] [PATCH] spec: mingw: add deps for genprotocol.pl usage

Cole Robinson posted 1 patch 4 years, 4 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/2236b4ca5653b3a5b6cf423f9792745b748a0fbe.1575393110.git.crobinso@redhat.com
mingw-libvirt.spec.in | 4 ++++
1 file changed, 4 insertions(+)
[libvirt] [PATCH] spec: mingw: add deps for genprotocol.pl usage
Posted by Cole Robinson 4 years, 4 months ago
As of 0985a9597bb03 we no longer distribute generated files. mingw
needs to call genprotocol.pl itself, which means it needs rpcgen
and cpp installed.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 mingw-libvirt.spec.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index c29f3eeed2..fd9b729591 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -89,6 +89,10 @@ BuildRequires: mingw64-libssh2
 BuildRequires: mingw32-curl
 BuildRequires: mingw64-curl
 %endif
+BuildRequires: cpp
+%if 0%{?fedora} || 0%{?rhel} > 7
+BuildRequires: rpcgen
+%endif
 
 BuildArch:      noarch
 
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: mingw: add deps for genprotocol.pl usage
Posted by Daniel P. Berrangé 4 years, 4 months ago
On Tue, Dec 03, 2019 at 12:11:50PM -0500, Cole Robinson wrote:
> As of 0985a9597bb03 we no longer distribute generated files. mingw
> needs to call genprotocol.pl itself, which means it needs rpcgen
> and cpp installed.
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  mingw-libvirt.spec.in | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list