[PATCH 0/7] src: hardening of dnsmasq config file hostname handling

Daniel P. Berrangé via Devel posted 7 patches 2 weeks, 3 days ago
Failed in applying to current master (apply log)
src/conf/network_conf.c                       |  31 ++-
src/libvirt_private.syms                      |   1 +
src/util/virdnsmasq.c                         | 179 +++++++-----------
src/util/virutil.c                            |  50 +++++
src/util/virutil.h                            |   2 +
.../nat-network-bad-hostname.xml              |  22 +++
.../nat-network-dhcp-hosts-bad.xml            |  21 ++
.../nat-network-dns-hosts-bad.xml             |  26 +++
tests/networkxmlconftest.c                    |   3 +
tests/utiltest.c                              |  72 +++++++
tests/virschematest.c                         |   3 +
11 files changed, 286 insertions(+), 124 deletions(-)
create mode 100644 tests/networkxmlconfdata/nat-network-bad-hostname.xml
create mode 100644 tests/networkxmlconfdata/nat-network-dhcp-hosts-bad.xml
create mode 100644 tests/networkxmlconfdata/nat-network-dns-hosts-bad.xml
[PATCH 0/7] src: hardening of dnsmasq config file hostname handling
Posted by Daniel P. Berrangé via Devel 2 weeks, 3 days ago

Daniel P. Berrangé (7):
  src: add virHostnameValidate helper for validation
  conf: perform full validation of hostnames / domain names
  src: remove fallback when opening dnsmasq addnhosts file fails
  src: use virFileRewrite for dnsmasq addnhosts file
  src: remove fallback when opening dnsmasq hosts file fails
  src: use virFileRewrite for dnsmasq hosts file
  util: sanity check dnsmasq hosts/addnhosts lines for no whitespace

 src/conf/network_conf.c                       |  31 ++-
 src/libvirt_private.syms                      |   1 +
 src/util/virdnsmasq.c                         | 179 +++++++-----------
 src/util/virutil.c                            |  50 +++++
 src/util/virutil.h                            |   2 +
 .../nat-network-bad-hostname.xml              |  22 +++
 .../nat-network-dhcp-hosts-bad.xml            |  21 ++
 .../nat-network-dns-hosts-bad.xml             |  26 +++
 tests/networkxmlconftest.c                    |   3 +
 tests/utiltest.c                              |  72 +++++++
 tests/virschematest.c                         |   3 +
 11 files changed, 286 insertions(+), 124 deletions(-)
 create mode 100644 tests/networkxmlconfdata/nat-network-bad-hostname.xml
 create mode 100644 tests/networkxmlconfdata/nat-network-dhcp-hosts-bad.xml
 create mode 100644 tests/networkxmlconfdata/nat-network-dns-hosts-bad.xml

-- 
2.56.0