remote: install the secrets unit only for systemd

[PATCH] remote: install the secrets unit only for systemd

Roman Bogorodskiy posted 1 patch 1 week, 5 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20260503091237.14437-1-bogorodskiy@gmail.com

src/remote/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] remote: install the secrets unit only for systemd

Posted by Roman Bogorodskiy 1 week, 5 days ago

Install the secrets unit only when the init script is systemd.

Fixes: 2db552dc6ac17596720071fa91181055db7b82ee
Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
---
 src/remote/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/remote/meson.build b/src/remote/meson.build
index dfd61df62f..25995fdbc2 100644
--- a/src/remote/meson.build
+++ b/src/remote/meson.build
@@ -345,7 +345,7 @@ endif
 
 # The monolithic libvirt daemon only attempts to load the
 # secrets encryption credentials if the secret driver is enabled
-if conf.has('WITH_SECRETS')
+if conf.has('WITH_SECRETS') and init_script == 'systemd'
   secret_dropin_conf = configuration_data({
     'localstatedir': localstatedir,
   })
-- 
2.52.0

Re: [PATCH] remote: install the secrets unit only for systemd

Posted by Peter Krempa via Devel 1 week, 4 days ago

On Sun, May 03, 2026 at 11:12:37 +0200, Roman Bogorodskiy wrote:
> Install the secrets unit only when the init script is systemd.
> 
> Fixes: 2db552dc6ac17596720071fa91181055db7b82ee
> Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
> ---
>  src/remote/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/remote/meson.build b/src/remote/meson.build
> index dfd61df62f..25995fdbc2 100644
> --- a/src/remote/meson.build
> +++ b/src/remote/meson.build
> @@ -345,7 +345,7 @@ endif
>  
>  # The monolithic libvirt daemon only attempts to load the
>  # secrets encryption credentials if the secret driver is enabled
> -if conf.has('WITH_SECRETS')
> +if conf.has('WITH_SECRETS') and init_script == 'systemd'
>    secret_dropin_conf = configuration_data({
>      'localstatedir': localstatedir,
>    })
> -- 
> 2.52.0
> 

Reviewed-by: Peter Krempa <pkrempa@redhat.com>