[PATCH v2 1/2] hyperv: use constants for xml namespaces

Jonathon Jongsma via Devel posted 2 patches 3 days, 2 hours ago
[PATCH v2 1/2] hyperv: use constants for xml namespaces
Posted by Jonathon Jongsma via Devel 3 days, 2 hours ago
Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
---
 src/hyperv/hyperv_wmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c
index dab7abe8cf..14df670fa1 100644
--- a/src/hyperv/hyperv_wmi.c
+++ b/src/hyperv/hyperv_wmi.c
@@ -513,13 +513,13 @@ hypervSerializeEprParam(hypervParam *p, hypervPrivate *priv,
         return -1;
     }
 
-    if (!ws_xml_ns_add(xmlNodeParam, "http://schemas.xmlsoap.org/ws/2004/08/addressing", "a")) {
+    if (!ws_xml_ns_add(xmlNodeParam, XML_NS_ADDRESSING, "a")) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                        _("Could not set namespace address for xmlNodeParam"));
         return -1;
     }
 
-    if (!ws_xml_ns_add(xmlNodeParam, "http://schemas.dmtf.org/wbem/wsman/1/wsman.xsd", "w")) {
+    if (!ws_xml_ns_add(xmlNodeParam, XML_NS_WS_MAN, "w")) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                        _("Could not set wsman namespace address for xmlNodeParam"));
         return -1;
-- 
2.53.0
Re: [PATCH v2 1/2] hyperv: use constants for xml namespaces
Posted by Peter Krempa via Devel 14 hours ago
On Fri, Mar 20, 2026 at 16:19:22 -0500, Jonathon Jongsma via Devel wrote:
> Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>

These come from openwsman's 'wsman-names.h' header.


> ---
>  src/hyperv/hyperv_wmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>