util: implement virHostCPUGetOnlineBitmap() for FreeBSD

[PATCH] util: implement virHostCPUGetOnlineBitmap() for FreeBSD

Roman Bogorodskiy posted 1 patch 1 week, 5 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20260311182413.8206-1-bogorodskiy@gmail.com

src/util/virhostcpu.c | 13 +++++++++++++
1 file changed, 13 insertions(+)

Expand all Fold all

[PATCH] util: implement virHostCPUGetOnlineBitmap() for FreeBSD

Posted by Roman Bogorodskiy 1 week, 5 days ago

Implement virHostCPUGetOnlineBitmap() for FreeBSD. As FreeBSD
supports neither plugging nor taking CPUs offline,
all CPUs are always online.

Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
---
 src/util/virhostcpu.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
index 7cecb4b2c8..8688b6ec67 100644
--- a/src/util/virhostcpu.c
+++ b/src/util/virhostcpu.c
@@ -1120,6 +1120,19 @@ virHostCPUGetOnlineBitmap(void)
 
     virFileReadValueBitmap(&ret, "%s/cpu/online", SYSFS_SYSTEM_PATH);
 
+    return ret;
+#elif defined(__FreeBSD__)
+    virBitmap *ret = NULL;
+    int ncpus = virHostCPUGetCountAppleFreeBSD();
+
+    if (ncpus == -1)
+        return ret;
+
+    /* FreeBSD does not support CPU hotplug, so it is safe to assume
+     * that all available CPUs are online */
+    ret = virBitmapNew(ncpus);
+    virBitmapSetAll(ret);
+
     return ret;
 #else
     virReportError(VIR_ERR_NO_SUPPORT, "%s",
-- 
2.52.0

Re: [PATCH] util: implement virHostCPUGetOnlineBitmap() for FreeBSD

Posted by Michal Prívozník via Devel 1 week, 4 days ago

On 3/11/26 19:24, Roman Bogorodskiy wrote:
> Implement virHostCPUGetOnlineBitmap() for FreeBSD. As FreeBSD
> supports neither plugging nor taking CPUs offline,
> all CPUs are always online.
> 
> Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
> ---
>  src/util/virhostcpu.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Michal