hyperv: Clean up unnecessary header includes

[PATCH] hyperv: Clean up unnecessary header includes

Jonathon Jongsma via Devel posted 1 patch 1 week, 6 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20260217160028.2998587-1-jjongsma@redhat.com

src/hyperv/hyperv_util.c | 2 +-
src/hyperv/hyperv_wmi.c  | 2 +-
src/hyperv/hyperv_wmi.h  | 1 -
3 files changed, 2 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH] hyperv: Clean up unnecessary header includes

Posted by Jonathon Jongsma via Devel 1 week, 6 days ago

Remove some unused or over-broad includes from headers, push some
includes down to .c files when the only user is the implementation.

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
---
 src/hyperv/hyperv_util.c | 2 +-
 src/hyperv/hyperv_wmi.c  | 2 +-
 src/hyperv/hyperv_wmi.h  | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/hyperv/hyperv_util.c b/src/hyperv/hyperv_util.c
index 37a1b1a249..120c0b1bdb 100644
--- a/src/hyperv/hyperv_util.c
+++ b/src/hyperv/hyperv_util.c
@@ -23,8 +23,8 @@
 
 #include "internal.h"
 #include "viralloc.h"
+#include "virerror.h"
 #include "virlog.h"
-#include "hyperv_private.h"
 #include "hyperv_util.h"
 
 #define VIR_FROM_THIS VIR_FROM_HYPERV
diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c
index eee42b5c70..1ca1e0b5db 100644
--- a/src/hyperv/hyperv_wmi.c
+++ b/src/hyperv/hyperv_wmi.c
@@ -40,7 +40,7 @@
 #include "hyperv_wmi.h"
 #include "virstring.h"
 #include "virlog.h"
-#include "virxml.h"
+#include "virhash.h"
 
 #define VIR_FROM_THIS VIR_FROM_HYPERV
 
diff --git a/src/hyperv/hyperv_wmi.h b/src/hyperv/hyperv_wmi.h
index 9093aec455..9fad0712a2 100644
--- a/src/hyperv/hyperv_wmi.h
+++ b/src/hyperv/hyperv_wmi.h
@@ -26,7 +26,6 @@
 #include "virbuffer.h"
 #include "hyperv_private.h"
 #include "hyperv_wmi_classes.h"
-#include "virhash.h"
 
 
 #define HYPERV_WQL_QUERY_INITIALIZER { NULL, NULL }
-- 
2.53.0

Re: [PATCH] hyperv: Clean up unnecessary header includes

Posted by Michal Prívozník via Devel 1 week, 5 days ago

On 2/17/26 17:00, Jonathon Jongsma via Devel wrote:
> Remove some unused or over-broad includes from headers, push some
> includes down to .c files when the only user is the implementation.
> 
> Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
> ---
>  src/hyperv/hyperv_util.c | 2 +-
>  src/hyperv/hyperv_wmi.c  | 2 +-
>  src/hyperv/hyperv_wmi.h  | 1 -
>  3 files changed, 2 insertions(+), 3 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Michal