[v1] esx: Form URLs containing IPv6 addresses correctly

[PATCH 1/3] esx: Debug URL just before opening with curl

Posted by Richard W.M. Jones via Devel 6 days, 18 hours ago

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
 src/esx/esx_vi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c
index 3264afc13a..c5ecb22bc4 100644
--- a/src/esx/esx_vi.c
+++ b/src/esx/esx_vi.c
@@ -383,6 +383,7 @@ esxVI_CURL_Download(esxVI_CURL *curl, const char *url, char **content,
     }
 
     VIR_WITH_MUTEX_LOCK_GUARD(&curl->lock) {
+        VIR_DEBUG("URL: %s", url);
         curl_easy_setopt(curl->handle, CURLOPT_URL, url);
         curl_easy_setopt(curl->handle, CURLOPT_RANGE, range);
         curl_easy_setopt(curl->handle, CURLOPT_WRITEDATA, &buffer);
@@ -423,6 +424,7 @@ esxVI_CURL_Upload(esxVI_CURL *curl, const char *url, const char *content)
     }
 
     VIR_WITH_MUTEX_LOCK_GUARD(&curl->lock) {
+        VIR_DEBUG("URL: %s", url);
         curl_easy_setopt(curl->handle, CURLOPT_URL, url);
         curl_easy_setopt(curl->handle, CURLOPT_RANGE, NULL);
         curl_easy_setopt(curl->handle, CURLOPT_READDATA, &content);
@@ -1220,6 +1222,7 @@ esxVI_Context_Execute(esxVI_Context *ctx, const char *methodName,
         return -1;
 
     VIR_WITH_MUTEX_LOCK_GUARD(&ctx->curl->lock) {
+        VIR_DEBUG("URL: %s", ctx->url);
         curl_easy_setopt(ctx->curl->handle, CURLOPT_URL, ctx->url);
         curl_easy_setopt(ctx->curl->handle, CURLOPT_RANGE, NULL);
         curl_easy_setopt(ctx->curl->handle, CURLOPT_WRITEDATA, &buffer);
-- 
2.52.0

Re: [PATCH 1/3] esx: Debug URL just before opening with curl

Posted by Michal Prívozník via Devel 6 days, 17 hours ago

On 1/26/26 12:05, Richard W.M. Jones wrote:
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> ---
>  src/esx/esx_vi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c
> index 3264afc13a..c5ecb22bc4 100644
> --- a/src/esx/esx_vi.c
> +++ b/src/esx/esx_vi.c
> @@ -383,6 +383,7 @@ esxVI_CURL_Download(esxVI_CURL *curl, const char *url, char **content,
>      }
>  
>      VIR_WITH_MUTEX_LOCK_GUARD(&curl->lock) {
> +        VIR_DEBUG("URL: %s", url);
>          curl_easy_setopt(curl->handle, CURLOPT_URL, url);
>          curl_easy_setopt(curl->handle, CURLOPT_RANGE, range);
>          curl_easy_setopt(curl->handle, CURLOPT_WRITEDATA, &buffer);
> @@ -423,6 +424,7 @@ esxVI_CURL_Upload(esxVI_CURL *curl, const char *url, const char *content)
>      }
>  
>      VIR_WITH_MUTEX_LOCK_GUARD(&curl->lock) {
> +        VIR_DEBUG("URL: %s", url);
>          curl_easy_setopt(curl->handle, CURLOPT_URL, url);
>          curl_easy_setopt(curl->handle, CURLOPT_RANGE, NULL);
>          curl_easy_setopt(curl->handle, CURLOPT_READDATA, &content);
> @@ -1220,6 +1222,7 @@ esxVI_Context_Execute(esxVI_Context *ctx, const char *methodName,
>          return -1;
>  
>      VIR_WITH_MUTEX_LOCK_GUARD(&ctx->curl->lock) {
> +        VIR_DEBUG("URL: %s", ctx->url);
>          curl_easy_setopt(ctx->curl->handle, CURLOPT_URL, ctx->url);
>          curl_easy_setopt(ctx->curl->handle, CURLOPT_RANGE, NULL);
>          curl_easy_setopt(ctx->curl->handle, CURLOPT_WRITEDATA, &buffer);

Alternatively, just put one VIR_DEBUG() into esxVI_CURL_Perform()

Michal

Re: [PATCH 1/3] esx: Debug URL just before opening with curl

Posted by Richard W.M. Jones via Devel 6 days, 15 hours ago

On Mon, Jan 26, 2026 at 01:58:37PM +0100, Michal Prívozník wrote:
> On 1/26/26 12:05, Richard W.M. Jones wrote:
> > Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> > ---
> >  src/esx/esx_vi.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c
> > index 3264afc13a..c5ecb22bc4 100644
> > --- a/src/esx/esx_vi.c
> > +++ b/src/esx/esx_vi.c
> > @@ -383,6 +383,7 @@ esxVI_CURL_Download(esxVI_CURL *curl, const char *url, char **content,
> >      }
> >  
> >      VIR_WITH_MUTEX_LOCK_GUARD(&curl->lock) {
> > +        VIR_DEBUG("URL: %s", url);
> >          curl_easy_setopt(curl->handle, CURLOPT_URL, url);
> >          curl_easy_setopt(curl->handle, CURLOPT_RANGE, range);
> >          curl_easy_setopt(curl->handle, CURLOPT_WRITEDATA, &buffer);
> > @@ -423,6 +424,7 @@ esxVI_CURL_Upload(esxVI_CURL *curl, const char *url, const char *content)
> >      }
> >  
> >      VIR_WITH_MUTEX_LOCK_GUARD(&curl->lock) {
> > +        VIR_DEBUG("URL: %s", url);
> >          curl_easy_setopt(curl->handle, CURLOPT_URL, url);
> >          curl_easy_setopt(curl->handle, CURLOPT_RANGE, NULL);
> >          curl_easy_setopt(curl->handle, CURLOPT_READDATA, &content);
> > @@ -1220,6 +1222,7 @@ esxVI_Context_Execute(esxVI_Context *ctx, const char *methodName,
> >          return -1;
> >  
> >      VIR_WITH_MUTEX_LOCK_GUARD(&ctx->curl->lock) {
> > +        VIR_DEBUG("URL: %s", ctx->url);
> >          curl_easy_setopt(ctx->curl->handle, CURLOPT_URL, ctx->url);
> >          curl_easy_setopt(ctx->curl->handle, CURLOPT_RANGE, NULL);
> >          curl_easy_setopt(ctx->curl->handle, CURLOPT_WRITEDATA, &buffer);
> 
> Alternatively, just put one VIR_DEBUG() into esxVI_CURL_Perform()

I'm going to do a V2 which fixes this and one other cosmetic thing.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW