[PATCH 03/29] schemas: Allow JSON format for NVRAM

Andrea Bolognani via Devel posted 29 patches 1 week, 3 days ago
[PATCH 03/29] schemas: Allow JSON format for NVRAM
Posted by Andrea Bolognani via Devel 1 week, 3 days ago
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/conf/schemas/domaincommon.rng | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincommon.rng
index c799bf04b7..ea5f8dac85 100644
--- a/src/conf/schemas/domaincommon.rng
+++ b/src/conf/schemas/domaincommon.rng
@@ -8035,6 +8035,7 @@
     <choice>
       <value>raw</value>
       <value>qcow2</value>
+      <value>json</value>
     </choice>
   </define>
 
-- 
2.52.0
Re: [PATCH 03/29] schemas: Allow JSON format for NVRAM
Posted by Daniel P. Berrangé via Devel 1 day, 1 hour ago
On Mon, Dec 29, 2025 at 12:40:22AM +0100, Andrea Bolognani via Devel wrote:
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/conf/schemas/domaincommon.rng | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincommon.rng
> index c799bf04b7..ea5f8dac85 100644
> --- a/src/conf/schemas/domaincommon.rng
> +++ b/src/conf/schemas/domaincommon.rng
> @@ -8035,6 +8035,7 @@
>      <choice>
>        <value>raw</value>
>        <value>qcow2</value>
> +      <value>json</value>
>      </choice>
>    </define>

The firmware JSON files are not providing NVRAM storage, and 'json' is not
a valid QEMU blockdev driver either. This is overloading different concepts
and doesn't make sense IMHO.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|