Was going to push it right away, but there were a little more changes
than I expected, so sending v2.

Changes from v1:

 - Patch 1/3 (implementation) updated to pass "mac=" MAC address
   configuration for the slirp interface,
 - Patch 2/3 updated to remove error if MAC address is specified
   and squashed into 1/3 as there was only a single code chunk left.

Roman Bogorodskiy (2):
  bhyve: implement SLIRP networking
  docs: drvbhyve: document SLIRP networking

 docs/drvbhyve.rst                             | 24 ++++++++++++++
 src/bhyve/bhyve_command.c                     | 10 ++++--
 src/bhyve/bhyve_domain.c                      | 12 ++++++-
 .../bhyvexml2argv-slirp-ip.xml                | 22 +++++++++++++
 .../bhyvexml2argv-slirp-mac-addr.args         | 10 ++++++
 .../bhyvexml2argv-slirp-mac-addr.ldargs       |  4 +++
 .../bhyvexml2argv-slirp-mac-addr.xml          | 22 +++++++++++++
 .../bhyvexml2argv-slirp.args                  | 10 ++++++
 .../bhyvexml2argv-slirp.ldargs                |  4 +++
 .../bhyvexml2argvdata/bhyvexml2argv-slirp.xml | 21 ++++++++++++
 tests/bhyvexml2argvtest.c                     |  3 ++
 .../bhyvexml2xmlout-slirp.xml                 | 32 +++++++++++++++++++
 tests/bhyvexml2xmltest.c                      |  1 +
 13 files changed, 172 insertions(+), 3 deletions(-)
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-slirp-ip.xml
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-slirp-mac-addr.args
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-slirp-mac-addr.ldargs
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-slirp-mac-addr.xml
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-slirp.args
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-slirp.ldargs
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-slirp.xml
 create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-slirp.xml

-- 
2.51.2

On 12/11/25 2:18 PM, Roman Bogorodskiy wrote:
> Was going to push it right away, but there were a little more changes
> than I expected, so sending v2.
> 
> Changes from v1:
> 
>   - Patch 1/3 (implementation) updated to pass "mac=" MAC address
>     configuration for the slirp interface,
>   - Patch 2/3 updated to remove error if MAC address is specified
>     and squashed into 1/3 as there was only a single code chunk left.

Reviewed-by: Laine Stump <laine@redhat.com>

On 12/15/25 1:08 PM, Laine Stump wrote:
> On 12/11/25 2:18 PM, Roman Bogorodskiy wrote:
>> Was going to push it right away, but there were a little more changes
>> than I expected, so sending v2.
>>
>> Changes from v1:
>>
>>   - Patch 1/3 (implementation) updated to pass "mac=" MAC address
>>     configuration for the slirp interface,
>>   - Patch 2/3 updated to remove error if MAC address is specified
>>     and squashed into 1/3 as there was only a single code chunk left.
> 
> Reviewed-by: Laine Stump <laine@redhat.com>

Oops - I forgot to say you should update the example bhyve commandline 
in the commit log message to show how the mac address is set.

  Laine Stump wrote:

> On 12/15/25 1:08 PM, Laine Stump wrote:
> > On 12/11/25 2:18 PM, Roman Bogorodskiy wrote:
> > > Was going to push it right away, but there were a little more changes
> > > than I expected, so sending v2.
> > > 
> > > Changes from v1:
> > > 
> > >   - Patch 1/3 (implementation) updated to pass "mac=" MAC address
> > >     configuration for the slirp interface,
> > >   - Patch 2/3 updated to remove error if MAC address is specified
> > >     and squashed into 1/3 as there was only a single code chunk left.
> > 
> > Reviewed-by: Laine Stump <laine@redhat.com>
> 
> Oops - I forgot to say you should update the example bhyve commandline in
> the commit log message to show how the mac address is set.

Pushed with the commit message updated. In a final round of testing I
also noticed two issues:

 - I originally misplaced the ",mac=" option
 - In the docs, I used libvirt version 11.11.0 instead of 12.0.0.

Pushed the series with these items fixed.

Thanks,
Roman