[PATCH] docs/deprecated: Remove undeprecated SMP description

Zhao Liu posted 1 patch an hour ago
Failed in applying to current master (apply log)
docs/about/deprecated.rst | 14 --------------
1 file changed, 14 deletions(-)
[PATCH] docs/deprecated: Remove undeprecated SMP description
Posted by Zhao Liu an hour ago
"Unsupported 'parameter=1' SMP configuration" was proposed to be
deprecated in the commit 54c4ea8f3ae6 ("hw/core/machine-smp: Deprecate
unsupported "parameter=1" SMP configurations").

But the related code was reverted later in the commit 9d7950edb0cd
("hw/core: allow parameter=1 for SMP topology on any machine").

Thus, this SMP behavior is still valid and is not actually deprecated.

Remove outdated document descriptions.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 docs/about/deprecated.rst | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 03e29915f0aa..bbfcce4a1ab3 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -54,20 +54,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``.
 However, short-form booleans are deprecated and full explicit ``arg_name=on``
 form is preferred.
 
-``-smp`` (Unsupported "parameter=1" SMP configurations) (since 9.0)
-'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
-
-Specified CPU topology parameters must be supported by the machine.
-
-In the SMP configuration, users should provide the CPU topology parameters that
-are supported by the target machine.
-
-However, historically it was allowed for users to specify the unsupported
-topology parameter as "1", which is meaningless. So support for this kind of
-configurations (e.g. -smp drawers=1,books=1,clusters=1 for x86 PC machine) is
-marked deprecated since 9.0, users have to ensure that all the topology members
-described with -smp are supported by the target machine.
-
 QEMU Machine Protocol (QMP) commands
 ------------------------------------
 
-- 
2.34.1
Re: [PATCH] docs/deprecated: Remove undeprecated SMP description
Posted by Markus Armbruster via Devel an hour ago
Zhao Liu <zhao1.liu@intel.com> writes:

> "Unsupported 'parameter=1' SMP configuration" was proposed to be
> deprecated in the commit 54c4ea8f3ae6 ("hw/core/machine-smp: Deprecate
> unsupported "parameter=1" SMP configurations").
>
> But the related code was reverted later in the commit 9d7950edb0cd
> ("hw/core: allow parameter=1 for SMP topology on any machine").
>
> Thus, this SMP behavior is still valid and is not actually deprecated.
>
> Remove outdated document descriptions.
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>  docs/about/deprecated.rst | 14 --------------
>  1 file changed, 14 deletions(-)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 03e29915f0aa..bbfcce4a1ab3 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -54,20 +54,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``.
>  However, short-form booleans are deprecated and full explicit ``arg_name=on``
>  form is preferred.
>  
> -``-smp`` (Unsupported "parameter=1" SMP configurations) (since 9.0)
> -'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> -
> -Specified CPU topology parameters must be supported by the machine.
> -
> -In the SMP configuration, users should provide the CPU topology parameters that
> -are supported by the target machine.
> -
> -However, historically it was allowed for users to specify the unsupported
> -topology parameter as "1", which is meaningless. So support for this kind of
> -configurations (e.g. -smp drawers=1,books=1,clusters=1 for x86 PC machine) is
> -marked deprecated since 9.0, users have to ensure that all the topology members
> -described with -smp are supported by the target machine.
> -
>  QEMU Machine Protocol (QMP) commands
>  ------------------------------------

Reviewed-by: Markus Armbruster <armbru@redhat.com>